Moveit: Modularize Setup Assistant

[rhaschke]

In #1375, @MohmadAyman did a great initial work to modularize MSA. However, as pointed out in https://github.com/ros-planning/moveit/pull/1375#pullrequestreview-212596707 and https://github.com/ros-planning/moveit/pull/1375#issuecomment-480944057 there are several open TODOs to finish this attempt and merge the branch feature-modular-msa into master:

• Data modularization: Each widget should store its data locally. Currently all the data is stored centrally in MoveItConfigData.
• Add loading of existing config files to allow proper editing of files. This will render the ConfigurationFilesWidget obsolete as there is no danger to overwrite manual changes.
• Use Qt's UI files to layout widgets - instead of manually creating and layouting items.

[MohmadAyman]

Use Qt's UI files to layout widgets - instead of manually creating and layouting items.

Hey @rhaschke , sorry for the late reply.
Are we planning to do that for all the existing widgets? Do you think it is necessary for modularizing the MSA?

[rhaschke]

It's not necessary, but a great improvement that will facilitate modifying the GUI layouts in the future.

[MohmadAyman]

Would it be okay to add it to a separate issue maybe, or just not making it
a prerequisite to merge into master?

I believe the bigger the issue the less motivating it is to work on it.

On Sun, 25 Aug 2019, 19:26 Robert Haschke, [e-mail] wrote:

It's not necessary, but a great improvement that will facilitate modifying
the GUI layouts in the future.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ros-planning/moveit/issues/1527?email_source=notifications&email_token=ACOJLD32JSKQKSUKHIAT7NLQGK6EBA5CNFSM4H4FME52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5CX2CI#issuecomment-524647689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACOJLD75NW65URUC4B6V6FTQGK6EBANCNFSM4H4FME5Q
.

[rhaschke]

Sure.

[MohmadAyman]

Hey @rhaschke , Do you think there is a way to rebase this to work with melodic without having to solve huge numbers of merge conflicts? so I wouldnt have to install ubuntu 16.

[rhaschke]

Done. Rebasing onto melodic-devel was done without any conflicts. Do you prefer a rebase to melodic or to master? The latter I already prepared but didn't yet push.

[MohmadAyman]

Thank you! the latter should work fine!

On Sun, 20 Oct 2019, 17:26 Robert Haschke, [e-mail] wrote:

Done. Rebasing onto melodic-devel was done without any conflicts. Do you
prefer a rebase to melodic or to master? The latter I already prepared but
didn't yet push.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ros-planning/moveit/issues/1527?email_source=notifications&email_token=ACOJLDYOOMUJK57JYZEOWWDQPR2DTA5CNFSM4H4FME52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYMTGA#issuecomment-544262552,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOJLD5EDUSKVCCLKTRNDBTQPR2DTANCNFSM4H4FME5Q
.

[rhaschke]

Could you please clarify: You do prefer master over melodic-devel?

[MohmadAyman]

Okay, on melodic-devel would be nice, as long as it is ros melodic my
problem is solved, thanks!

On Mon, 21 Oct 2019, 13:17 Robert Haschke, [e-mail] wrote:

Could you please clarify: You do prefer master over melodic-devel?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ros-planning/moveit/issues/1527?email_source=notifications&email_token=ACOJLD3OXJXVMRR7M7PZ2BTQPWFWBA5CNFSM4H4FME52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBZ664A#issuecomment-544468848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOJLD4JVGLTW7XFSLBBKF3QPWFWBANCNFSM4H4FME5Q
.

[rhaschke]

If you just need ROS Melodic, I suggest rebasing onto master, which should be the target branch for this contribution anyways.

[rhaschke]

Done. Travis is working on it: https://travis-ci.org/ros-planning/moveit/builds/600723588
Note that there are some issues reported by Travis (due to stronger error checking).

[davetcoleman]

@MohmadAyman I'm noticing the Modular MSA branch is 14 months stale, any chance we could finish that effort up?

[MohmadAyman]

Yes, sadly I couldn't realize an implementation that would work with the last set of requirements we've talked about with @rhaschke