Moveable: Change Angular peer dependencies to allow versions greater than 8

Created on 7 Jul 2020  Â·  2Comments  Â·  Source: daybrush/moveable

Environments

  • Framework name: Angular
  • Framework version: 10

Description

The Angular 9 to 10 update throws this error:

Package "ngx-moveable" has an incompatible peer dependency to "@angular/core" (requires "^8.0.3" (extended), would install "10.0.2").
Package "ngx-moveable" has an incompatible peer dependency to "@angular/common" (requires "^8.0.3" (extended), would install "10.0.2").
✖ Migration failed: Incompatible peer dependencies found.

A flag can be used to ignore these incompatibilities during the update, but unmet peer dependencies cause issues later on as well.

Looking at the source, it should work fine with never Angular versions, so I propose to change the peer dependencies from:

"peerDependencies": {
  "@angular/common": "^8.0.3",
  "@angular/core": "^8.0.3"
}

to:

"peerDependencies": {
  "@angular/common": ">=8",
  "@angular/core": ">=8"
}

Would that be acceptable?

Angular bug complete

All 2 comments

@kristijanbambir
Thank you

I'll fix for next release.

@kristijanbambir

moveable's new version is released.

  • moveable 0.18.3
  • react-moveable 0.21.4
  • preact-moveable 0.20.5
  • ngx-moveable 0.14.1
  • svelte-moveable 0.9.1

Check it again.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pistell picture pistell  Â·  4Comments

adityakrshnn picture adityakrshnn  Â·  4Comments

masoudelahi picture masoudelahi  Â·  5Comments

copthuy picture copthuy  Â·  4Comments

probil picture probil  Â·  4Comments