Moshi: Obfuscation and enums

[gabrielittner]

The integrated EnumJsonAdapter in StandardJsonAdapters can't be instantiated because the field name doesn't match the name anymore.

My solution is to annotate enums that are used with Moshi with @JsonClass(generateAdapter = false) and then keep the field names for annotated enums:

-keepclassmembernames @com.squareup.moshi.JsonClass class * extends java.lang.Enum {
    <fields>;
}

This way it's possible to avoid keeping all enums.

Do you think it would make sense to add it to the shipped Proguard config?

[swankjesse]

Yeah, I like that.

[ezamelczykespeo]

Does that mean that enums will only work with moshi if they're annotated with @JsonClass(generateAdapter = false)?

[gabrielittner]

If you're using proguard/R8 and they would rename or remove one of the enum fields, yes.

[ezamelczykespeo]

I don't understand why @Json(name = "name) isn't sufficient. Enums work with Gsons @SerializedName

[realdadfish]

@ezamelczykespeo Issue probably resides in this line:

https://github.com/square/moshi/blob/master/moshi/src/main/java/com/squareup/moshi/StandardJsonAdapters.java#L240

The Java method getEnumConstants() still gives back the literal enum names, not the obfuscated ones, so initializing Moshi with any enum adapter will crash with an AssertionError that wraps a NoSuchFieldException stemming from the failed reflection call.

[VarunBarad]

@gabrielittner you just saved my day. 🙇