Moshi: Do incremental annotation processing if possible

[swankjesse]

Should make things faster.
https://docs.gradle.org/nightly/userguide/java_plugin.html#sec:incremental_annotation_processing

[ZacSweers]

Unfortunately that only applies to java right now. No kotlin support any time soon :/

[yayaa]

Sooo... It's on its way for Kotlin 🙄

https://youtrack.jetbrains.com/issue/KT-23880#focus=streamItem-27-3344755.0-0

Now we need Moshi to be incremental even more 🤗

[ZacSweers]

Work's started :). Need KotlinPoet support first https://github.com/square/kotlinpoet/pull/647

[ber4444]

It seems to be broken now. I'm getting

[INFO] Incremental KAPT support is disabled. Processors that are not incremental: com.squareup.moshi.kotlin.codegen.JsonClassCodegenProcessor, javaslang.match.PatternsProcessor.

[technoir42]

@ber4444 you need to use 1.9.0-SNAPSHOT for now because there was no stable release of Moshi with incremental apt yet.

[ber4444]

when are you releasing an alpha/beta/RC?

really inconvenient to reference a snapshot in a prod app

it's about time anyways since last release is from Nov 8, 2018

[ZacSweers]

When it's ready and once we have confirmation that using a Filer will be supported. This will
require Kotlin 1.3.40 as the kapt support for it is targeting that. At the
moment, this would break compilation in Gradle builds with a pure Kotlin
codebase :/

On Mon, Jun 10, 2019 at 1:03 PM Gábor Berényi [e-mail]
wrote:

when are you releasing an alpha/beta/RC?

really inconvenient to reference a snapshot in a prod app

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/square/moshi/issues/589?email_source=notifications&email_token=AAKMJPR5TKQKNGY6SO5CP23PZ2JPVA5CNFSM4FHRHH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXKU6WQ#issuecomment-500518746,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKMJPVDVL4K3TNAC4R44ULPZ2JPVANCNFSM4FHRHH4Q
.

[ber4444]

Android Studio just updated to support 1.3.40 in the Kotlin plugin. At least in the beta channel. Hopefully you will release soon.

[ZacSweers]

Jetbrains did not include the final fix for us to safely use Filers in Android projects in 1.3.40, so we will need to wait. Hopefully a fast following 1.3.41.

https://github.com/JetBrains/kotlin/pull/2410

[technoir42]

The vast majority of Android projects would be unaffected by that bug since it's triggered by disabling BuildConfig generation when no other Java sources are present. The rest can work around it pretty easily by:

1. Re-enabling BuildConfig generation for the affected modules
2. Adding a dummy .java file to the affected modules
3. Staying on Moshi 1.8.0 until a new version of Kotlin with the fix is released

Since we've got a confirmation that Filer API will be supported I don't see why we have to wait any longer.

[ZacSweers]

I'd prefer to wait until jetbrains gets this over the finish line to be sure. Shipping a release with caveats isn't a great way to build trust, especially when those caveats are counting on something that has now slipped once. In the meantime if it works for you I think it's reasonable to just build from source and use that locally.

[yayaa]

Kotlin 1.3.41 is released - can we expect a new release now? :)

[swankjesse]

@ZacSweers ?

[ZacSweers]

It the final fix didn't make 1.3.41 either, but it's been merged. New target is 1.3.50

[ZacSweers]

But we've talked about doing an RC in the meantime :). Want to get the final metadata changes into kotlinpoet so we can cut over to them and use the RC to incubate that as well

[ber4444]

any news on this now that 1.3.50 is released

[swankjesse]

Yes, I think we can roll it all out soon.

[ursusursus]

https://github.com/gradle/gradle/issues/5277

[headsvk]

any updates? @swankjesse

[GuilhE]

With:

Gradle: 3.5.1
Kotlin: 1.3.50
Moshi: 1.8.0

Still getting:

[kapt] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: com.squareup.moshi.kotlin.codegen.JsonClassCodegenProcessor (NON_INCREMENTAL), javaslang.match.PatternsProcessor (NON_INCREMENTAL). |  
-- | --

[emartynov]

It should land in Moshi 1.9.0. We use 1.9.0 snapshot version and don't see this warning.

[robpridham-bbc]

I'm on 1.9.0 and I'm still seeing:

[WARN] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: javaslang.match.PatternsProcessor (NON_INCREMENTAL).

I can't be sure that Moshi is the one that introduces this processor, but obviously a search points me here. Any ideas?

[robpridham-bbc]

Update: I think I ran into a KAPT bug (https://youtrack.jetbrains.com/issue/KT-33056) that was invoked by using kapt.use.worker.api=true. Without this it seems fine.

[ZacSweers]

Shouldn't be Moshi. Could be another dependency bringing the kotlin
embeddable compiler as a dependency though?

On Tue, Nov 5, 2019 at 10:19 AM Rob Pridham [e-mail]
wrote:

I'm on 1.9.0 and I'm still seeing:

[WARN] Incremental annotation processing requested, but support is
disabled because the following processors are not incremental:
javaslang.match.PatternsProcessor (NON_INCREMENTAL).

I can't be sure that Moshi is the one that introduces this processor, but
obviously a search points me here. Any ideas?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/square/moshi/issues/589?email_source=notifications&email_token=AAKMJPVULQGVRLULHWZSNWDQSG2K5A5CNFSM4FHRHH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDDZQYQ#issuecomment-549951586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKMJPXQZ2ETWXDW6QA2QJDQSG2K5ANCNFSM4FHRHH4Q
.