Monica: Birthday of someone who's birthday is today is not shown on the dashboard

Created on 21 Jan 2018  ·  9Comments  ·  Source: monicahq/monica

I have a contact who's birthday is today, but it is not shown, while others (further in the future) are shown. I think it is useful to see who's birthdays I actually have to do something about -- today ;)

bug priority

Most helpful comment

This seems to be an issue still, sorry for brining it up again :)

All 9 comments

Fully agree on that and I think this can be merged with #740

Feedback from user:

One thing i've noticed is that my dashboard only shows upcoming reminders and not current ones (i.e. reminders for today)

I have hard time reproducing this bug. The thing is, the dashboard lists all reminders in the current month (regardless of the day we are in the current month).

Do you have any other details?

I just double checked - birthday from March 01st is not shown anymore in dashboard. I am no expert but suppose that the error may be somewhere here:

Once a reminder is passed, the next_expected_date is moved. In my case from 01.03.2018 to 01.03.2019. Therefore it is not showing up anymore in the dashboard, as it not between 01.03.2018 and 31.03.2018 anymore.

https://github.com/monicahq/monica/blob/8d2b21a0ce768f67342dcffca628b436a1fbfab7/app/Account.php#L531

🤦‍♂️

Damn, of course. How come I didn't see that. Sorry about this, it's definitely a bug, will fix it.

Ping! I keep missing things because of this :(

Ok. I'm on it!

This seems to be an issue still, sorry for brining it up again :)

This seems to be an issue still, sorry for brining it up again :) [2]

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mattdavenport picture mattdavenport  ·  3Comments

djaiss picture djaiss  ·  4Comments

vesper8 picture vesper8  ·  4Comments

jkbecker picture jkbecker  ·  3Comments

cynddl picture cynddl  ·  3Comments