Monica: Remove unnecessary loops and simplify model update

Created on 14 Jun 2017  路  5Comments  路  Source: monicahq/monica

Simplify model update:
https://github.com/monicahq/monica/blob/master/app/Http/Controllers/SettingsController.php#L57

Remove unnecessary loops:
https://github.com/monicahq/monica/blob/master/app/Http/Controllers/SettingsController.php#L74

picture aecdanjun

All 5 comments

These are being addressed by #253. You can check out the commits to see the new conventions being used.

yamakadi picture yamakadi on 15 Jun 2017
👍1

Thanks a lot for the issue. However, and I don't mean to be harsh, but this kind of issue is not really useful if it doesn't come with code that suggests an improvement. I love feature requests as issues or bug reports, but here, I don't really know what to do with it.

djaiss picture djaiss on 15 Jun 2017
👍1

Hum actually never mind, just saw a PR with your improvements. My bad. I'm out. Next time, reference the issue on the PR so I know :-D

djaiss picture djaiss on 15 Jun 2017
😄1

My bad :(

Sorry!

aecdanjun picture aecdanjun on 15 Jun 2017

Thanks for raising the issue! It's now fixed.

djaiss picture djaiss on 21 Jun 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

baisong picture baisong  路  3Comments
djaiss picture djaiss  路  3Comments
cynddl picture cynddl  路  3Comments
Svarto picture Svarto  路  3Comments
stralsi picture stralsi  路  4Comments