Monero: Build failing on Ubuntu 16.04.3 LTS

[ghost]

Did a make clean and the build failed. Deleted the entire monero directory, did a fresh git clone, and the build failed. Tried make release and the build still failed.

Log: https://paste.fedoraproject.org/paste/-8jNCsGWqi8mJJ37u75hkw

[moneromooo-monero]

Does this fix it ?

diff --git a/cmake/FindReadline.cmake b/cmake/FindReadline.cmake
index 7a11a27..9dd93d7 100644
--- a/cmake/FindReadline.cmake
+++ b/cmake/FindReadline.cmake
@@ -79,3 +79,6 @@ if(HAVE_COMPLETION_FUNCTION AND HAVE_COPY_TEXT)
   set(READLINE_FOUND TRUE)
 endif(HAVE_COMPLETION_FUNCTION AND HAVE_COPY_TEXT)

+if(Readline_LIBRARY STREQUAL "NOTFOUND")
+  set(Readline_LIBRARY "")
+endif()

[SpliffyMap]

For me yesterday approved pull requests failed too with Ubuntu. Also I see it at build.getmonero.org.

[ 48%] Linking CXX executable ../../bin/monerod /usr/bin/ld: ../../external/miniupnpc/libminiupnpc.a(miniupnpc.c.o): relocation R_X86_64_32 against.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
../../external/miniupnpc/libminiupnpc.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
src/daemon/CMakeFiles/daemon.dir/build.make:285: recipe for target 'bin/monerod' failed
make[3]: * [bin/monerod] Error 1
make[3]: Leaving directory '/home/dredas/Desktop/TESTCRYPTO/monero/build/release'
CMakeFiles/Makefile2:2692: recipe for target 'src/daemon/CMakeFiles/daemon.dir/all' failed
make[2]: * [src/daemon/CMakeFiles/daemon.dir/all] Error 2`

[ghost]

@moneromooo-monero Where do I insert that code? I assume some CMake.txt file? I’ve never done that before.

[jtgrassie]

3099 fixes this.

[SpliffyMap]

Not working for amd64 yet :)

[moneromooo-monero]

@moneromooo-monero Where do I insert that code? I assume some CMake.txt file? I’ve never done that before.

In the file the patch refers to ? "patch -p1" then paste that in. Or "paste -p1 < filename"

[jtgrassie]

@SpliffyMap yes you're right, looks like there are other issues beyond readline here.

[moneromooo-monero]

And about the miniupnpc one, https://github.com/monero-project/monero/pull/3103 might fix it.

[SpliffyMap]

For me it's good to go :+1:

[ghost]

PR #3099 fixes it for me

[SpliffyMap]

But just tried on my remote node, and got this one. Looks very similar.

[ghost]

Oops never mind. Build w/3099 failed for me as well.

[SpliffyMap]

Added same code #3103 to /external/unbound/CMakeLists.txt and it builds on node too now :+1:

[jtgrassie]

@xmr-eric it needs both #3103 & #3099 I think.

[SpliffyMap]

I used both too :)

[ghost]

Build completed using both PRs. Thanks!

[ghost]

I’ll wait for the PRs to get merged before I close this issue

[martinmatak]

@xmr-eric How did you build it "using both PRs" ? What does it mean? How do you use that code? I know only how to clone a repository, not sure how to clone pull requests? Do you clone then repository and PR, or just the latter?

I would also like to build it as soon as possible, even if it's still not merged with master branch.

[qskousen]

3103 and #3099 helped my build, but now it fails building unit tests:


/usr/bin/ld: ../gtest/libgtest.a(gtest-all.cc.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
../gtest/libgtest.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status


(I didn't ask it to build tests)

[Cova]

I think this is the same issue behind the problem I'm having getting the docker container to build. Except that #3103 and #3099 don't fix it for me.

[ 96%] Linking CXX executable ../../bin/monero-blockchain-export
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_filesystem.a(operations.o): relocation R_X86_64_32 against .rodata.str1.1' can not be used when making a shared object; recompile with -fPIC /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_filesystem.a: error adding symbols: Bad value collect2: error: ld returned 1 exit status make[3]: *** [bin/monero-blockchain-export] Error 1 src/blockchain_utilities/CMakeFiles/blockchain_export.dir/build.make:179: recipe for target 'bin/monero-blockchain-export' failed make[3]: Leaving directory '/src/build/release' CMakeFiles/Makefile2:2894: recipe for target 'src/blockchain_utilities/CMakeFiles/blockchain_export.dir/all' failed make[2]: *** [src/blockchain_utilities/CMakeFiles/blockchain_export.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs.... [ 97%] Linking CXX executable ../../bin/monero-blockchain-import /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_filesystem.a(operations.o): relocation R_X86_64_32 against.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_filesystem.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
src/blockchain_utilities/CMakeFiles/blockchain_import.dir/build.make:185: recipe for target 'bin/monero-blockchain-import' failed
make[3]: * [bin/monero-blockchain-import] Error 1
make[3]: Leaving directory '/src/build/release'
CMakeFiles/Makefile2:2842: recipe for target 'src/blockchain_utilities/CMakeFiles/blockchain_import.dir/all' failed
make[2]: [src/blockchain_utilities/CMakeFiles/blockchain_import.dir/all] Error 2
[ 97%] Linking CXX executable ../../bin/monerod
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_chrono.a(chrono.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/libboost_chrono.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
make[3]: [bin/monerod] Error 1
src/daemon/CMakeFiles/daemon.dir/build.make:286: recipe for target 'bin/monerod' failed
make[3]: Leaving directory '/src/build/release'
CMakeFiles/Makefile2:2770: recipe for target 'src/daemon/CMakeFiles/daemon.dir/all' failed
make[2]: [src/daemon/CMakeFiles/daemon.dir/all] Error 2
make[3]: Leaving directory '/src/build/release'
[ 97%] Built target obj_wallet
make[2]: Leaving directory '/src/build/release'
Makefile:138: recipe for target 'all' failed
make[1]: [all] Error 2
make[1]: Leaving directory '/src/build/release'
Makefile:68: recipe for target 'release-static' failed
make: * [release-static] Error 2
The command '/bin/sh -c rm -rf build && if [ -z "$NPROC" ];then make -j$(nproc) release-static;else make -j$NPROC release-static;fi' returned a non-zero code: 2

[dEBRUYNE-1]

@Cibale Use these steps:

1. git clone https://github.com/monero-project/monero.git

2. cd monero

3. git fetch origin pull/3103/head:3103-mooos-commit

4. git fetch origin pull/3099/head:3099-jtgrassies-commit

5. git checkout -b <name>

6. git merge 3099-jtgrassies-commit 3103-mooos-commit

7. make

[martinmatak]

@dEBRUYNE-1 thanks, but unfortunately it doesn't help me. I still can't build it. I receive error when linking CXX executable unit_tests

[ 97%] Linking CXX executable unit_tests
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/5/../../../../lib/libgtest.a(gtest-all.cc.o): relocation R_X86_64_32 against `.rodata' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-linux-gnu/5/../../../../lib/libgtest.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
tests/unit_tests/CMakeFiles/unit_tests.dir/build.make:1203: recipe for target 'tests/unit_tests/unit_tests' failed
make[3]: *** [tests/unit_tests/unit_tests] Error 1
make[3]: Leaving directory '/home/mmatak/dev/monero/build/release'
CMakeFiles/Makefile2:3869: recipe for target 'tests/unit_tests/CMakeFiles/unit_tests.dir/all' failed
make[2]: *** [tests/unit_tests/CMakeFiles/unit_tests.dir/all] Error 2
make[2]: Leaving directory '/home/mmatak/dev/monero/build/release'
Makefile:138: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/mmatak/dev/monero/build/release'
Makefile:64: recipe for target 'release-all' failed
make: *** [release-all] Error 2

[moneromooo-monero]

Works for me. What make/cmake command are you running exactly ?

[martinmatak]

@moneromooo-monero

I just type "make".. I am not sure how to give you more details than that.

@danrmiller

How did you recompile it with -fPIC ? Where to set that flag?

[moneromooo-monero]

Since it seems to be using libgtest from your OS, maybe the easiest is to remove it, so it will use the one bundled with monero, which uses -fPIC.

[martinmatak]

@moneromooo-monero

So I did sudo apt remove libgtest-dev , and then tried again with make, but I still get the same error..

EDIT:

Actually, after running make clean and then make, it worked.

Thanks!

[gldneagl]

Thanks Cibale... that worked for me too

[ralphholz]

Hi folks - I believe the current instructions for compiling this source code are wrong in README.md.

As indicated, it works without the libgtest-dev dependency.

Sending through a PR for consideration.

[mmortal03]

@Cova Did you or anyone else find a solution to your problem? I'm getting the same errors as you when trying to do a make release-static on the current master. Removing libgtest-dev and libboost-all-dev from the system doesn't help. I also tried @dEBRUYNE-1 's suggested steps to Cibale, and these also didn't help.