Monero: daemon output color problem

[SnaiLiuS]

Screenshot shows the problem:

[anonimal]

Color capable terminal? OS? Distro?

[iDunk5400]

That does not look like a recent Windows 10, probably Windows 7 or 8/8.1. So even if I PRed a possible solution, it would not work for you.

[SnaiLiuS]

Bad dreams guys: windows vista 6.0.6002 here.

daemon 0.10.3.1

btw, wallet-cli colorization is ok, only daemon color is broken since 0.10.1.0+ release

[anonimal]

windows vista 6.0.6002
0.10.1.0+

I don't see Vista in easylogging++'s compatability list.

[hyc]

http://monero.stackexchange.com/questions/3705/monero-win-x64-v0-10-2-1-cli-questions

[tikwanleap]

I have the same problem in Windows 10 64 bit since 0.10.1.0 release. Still happening in latest 0.10.3.1 release.

In hyc's stackexchange answer (https://superuser.com/questions/413073/windows-console-with-ansi-colors-handling/1050078) there is a mention of needing to call the SetConsoleMode function to get this working in Windows: https://msdn.microsoft.com/en-us/library/windows/desktop/ms686033(v=vs.85).aspx

I think the value that needs to be passed to the SetConsoleMode function is this:
ENABLE_VIRTUAL_TERMINAL_PROCESSING
0x0004

Also I noticed that only monerod.exe is missing colors except for when I type "status". The monero-wallet.cli.exe has correct colors.

[tikwanleap]

Could it be related to this issue?
https://github.com/muflihun/easyloggingpp/issues/363

[tikwanleap]

This looks like the solution.

https://github.com/bin-build/bin/commit/e4a038bb7f89b51f3eb794b83da6fa054d48900b

Apparently Windows 10 had ansi color support enabled by default at one point but more recent versions have it disabled by default.

The application needs to programmatically enable ansi color support.

[moneromooo-monero]

Any coder with Windows want to make a patch based on the above ? :)

[dEBRUYNE-1]

+bug

[dEBRUYNE-1]

+help wanted

[moneromooo-monero]

Fixed for some versions of Windows.

[ghost]

Vista is "dead" since 2 years:

https://support.microsoft.com/en-za/help/22882/windows-vista-end-of-support

So possibly its not worth to spend resources to make cosmetic things work for it.

Issue should be closable.

[moneromooo-monero]

Ah, I fixed it anwyay, since it was small stuff on top of other work I needed to do.
See https://github.com/monero-project/monero/pull/5688
I'll close this when it gets merged.