Monero: [feature] --language option for monero-wallet-cli

Created on 30 Sep 2016  路  12Comments  路  Source: monero-project/monero

There's a --password=... argument, but there isn't a --language="0" argument: generating a wallet forces a programmer to supply the language int via stdin, which isn't healthy.

resolved

Most helpful comment

The problem lies in simplewallet.cpp. I'll change it so that when --language=<int> is provided, the program continues. If the parameter is missing, the language-to-index mapping is printed and the user is prompted.

Please create another issue for your second request. Maybe I'll look into it, after I finished this one.

All 12 comments

I will try to look into that.

The problem lies within std::string simple_wallet::get_mnemonic_language(). There, a language out of a list provided by crypto::ElectrumWords::get_language_list has to be chosen be its index.

I did a little digging too, but C++ is way out of my league. I think there's some kind of options parsing class or something that clearly declares the CLI options, and different subcomponents peek into its instance to see if the option was provided already or not. I might be wrong though - I'll fetch a line number here soon.

This is similar with the "restore block height" input needed when restoring a deterministic seed; there's a --restore-height argument that has no effect when using --restore-deterministic-wallet, and again the index of the list of options needs to be supplied via stdin similarly.

The problem lies in simplewallet.cpp. I'll change it so that when --language=<int> is provided, the program continues. If the parameter is missing, the language-to-index mapping is printed and the user is prompted.

Please create another issue for your second request. Maybe I'll look into it, after I finished this one.

Also important for --restore-deterministic-wallet , there is no way to specify the language of words, I have found issues restoring wallets in spanish, documentation is not clear and test cases does not seem to have other languages for restore, any update on this? thx

Bump.
Writing an application and could use this feature right now since it is not possible to create a wallet via RPC.

Creating a wallet via RPC is supported in git master. 110b683152e4930247c88d426799d53943f19e72

@hyc thank you for referencing me to this, however I'm afraid over the past two days of my research that it's not officially documented anywhere, or to at least what I have searched for. Could this be suggested as well?

Thanks.

@mbe24 Did you ever make any progress on this?

monero-wallet-cli now has a --mnemonic-language option. It was added in #2293

+resolved

Was this page helpful?
0 / 5 - 0 ratings