Monaco-editor: Can't find variable: Intl error on Safari

Created on 19 Jan 2017 · 7Comments · Source: microsoft/monaco-editor

monaco-editor npm version: 0.8.0
Browser: Safari
OS: Mac

screen shot 2017-01-19 at 11 23 30 am

Repro: Visit https://microsoft.github.io/monaco-editor/playground.html on Safari

bug

Source

samelhusseini

All 7 comments

Caused by Microsoft/vscode#18539

@bpasero Can you please try running the editor in Safari, it appears Intl is not defined there.

alexdima on 21 Jan 2017

@alexandrudima I pushed a workaround, note that Intl is defined since Safari 10 (from 2014), so at some point we have to decide what we want to support on macOS.

bpasero on 21 Jan 2017

👍1

@bpasero Many thanks.

@microsoftsam What Safari version do you have?

alexdima on 21 Jan 2017

Safari Version 9.0.3

samelhusseini on 24 Jan 2017

Repro's on 9.1.2 as well. Looks like this has been fixed in the vscode repo. @alexandrudima is there going to be a monaco-editor 8.1 that will include this fix?

samelhusseini on 25 Jan 2017

@microsoftsam Yes, we are now in endgame and just did a test pass to uncover more bugs. 0.8.1 will come out, hopefully we can wrap it up at the end of this week.

alexdima on 25 Jan 2017

❤1

@bpasero @alexandrudima fwiw, this bug exists when using monaco-editor 0.8.0 in a webkit webview even on macOS 10.11 with Safari 10 installed. Hopefully monaco-editor will continue to support Safari 9 for the embedded scenario.