Moment-timezone: Do not log error when requiring moment-timezone multiple times in Node

[mderazon]

In Node it is quite common to require a module in multiple places

Right now if I require moment-timezone in multiple places I am getting

Moment Timezone 0.4.0 was already loaded with data from 2015d

That comes from this line (#212 )

This shouldn't be logged as an error and just clutters the server logs.
If anything, it should be a warning but in Node env it shouldn't be printed at all IMO

[mj1856]

Except that it can actually cause errors when the same time zone is defined more than once.

@timrwood - Perhaps we need to do more than just log an error in order to accommodate node.js scenarios?

[mderazon]

AFAIK node has a caching mechanism when requiring modules so that it shouldn't load module more than once

https://nodejs.org/api/modules.html#modules_caching

[mj1856]

If that's the case, then why would you be seeing the error message in your logs? It should only appear then if it wasn't already loaded in the cache, right?

[mj1856]

Perhaps you could supply a GIST with a minimal example that gives the error?

[mderazon]

I can't seem to be able to reproduce this.

I have a setup where I require moment-tz couple of times in my app and I also require a second module that requires moment-tz. When I try to replicate it I don't get the error message.

It looks like some quirk in npm that i'm not aware of, I will try to investigate it further and understand why it's being loaded twice in my app

[mderazon]

@mj1856 problem solved.

I had couple of old dependencies in my node_modules folder. After cleaning it up and restarting the module seems to be loading only once.

Sorry for the noise,

Thanks for your help !

[mj1856]

No problem, and glad to hear you got it working! :smile:

[FredKSchott]

We're still having this problem. We use moment-timezone inside of our app, but the ORM sequelize also uses moment-timezone internally. So we get this error.

What exact problems come from two different apps requiring moment? Can that problem still occur when a moment-timezone is loaded inside both the application and a dependency?

[mj1856]

@timrwood - Is there a better way to handle this? Loading into two different instances should be ok. It's only loading twice in the same instance that is problematic. Maybe just make the loading idempotent instead of throwing an error?

[jonahkirangi]

I seem to be running into the same issue as @FredKSchott. Any discussion regarding two different apps requiring moment?

Moment Timezone 0.3.1 was already loaded with data from 2015a

[poislagarde]

Same here, any suggestions?

[antoniopironti]

+1

Making the loading idempotent as suggested by @mj1856 would be ideal imo.

[johnRivs]

I went from 0.3.1 to 0.5.0. I'm requiring moment-timezone literally in a single file. Removed node_modules, did npm cache clean, then installed 0.5.0. I get Moment Timezone 0.3.1 was already loaded with data from 2015a.

How do I solve this?

[Braynid]

I'm getting this as well. Sequelize has moment-timezone as a dependency and almost certainly that causes the issue.

[jhohlfeld]

+1

Making the loading idempotent as suggested by @mj1856 and @antoniopironti would be ideal imo.

[loris]

Same issue here, let’s say I have an app using moment, and dependencies using moment-timezone (like Sequelize or Agenda), it displays Moment Timezone 0.3.1 was already loaded with data from 2015a

[rickhub]

I'm able to reproduct this problem if i install the package rschmukler/agenda, because it depends on [email protected] and [email protected] -> which in turn depends on [email protected].

[igormucsicska-planorama]

+1

[djtregear]

Hi I'm also getting "Moment Timezone 0.3.1 was already loaded with data from 2015a" when I require('agenda') from rschmukler/agenda.
It doesn't appear to be causing me any issues, just a little annoying.

[timrwood]

I've started work on #298, breaking moment-timezone into smaller es6 modules, which should make this problem easier to address.

The main problem is that the data loaded in an older version does not match the data loaded in a newer version.

I suppose we could compare the moment-timezone version and the tzdb versions and use the newest one.

[ee99ee]

Also getting this...

[niftylettuce]

still not fixed?

[loris]

It’s been almost a year, maybe we could remove the console.log polluting logs in the meantime?

[avingochea]

+1

[stephengardner]

Another month

[dawsonc623]

This is a pretty big pain for me, as the logging library used on an e-commerce project I am tasked with fixing suffers from this issue, so none of the logs have dates or times. It is insanely difficult for me to track down which logs occurred when to match logs to observed behavior in the system at the time they were observed.

At this time, I am reduced to sitting and waiting for the error to happen again to see exactly which logs are written, which means I am literally waiting for this company to lose more money. Can this be prioritized in any way? If you have not completed a fix, but have completed your reorganization, can it be placed in a branch so that the community (myself included) can try to complete the fix ourselves without stepping on your work?

I would also consider this a bug versus an enhancement; it prevents usage.

[loris]

Seriously, just remove the useless console.log line. I can’t even do it in a fork, moment-timezone is a dep of other libraries i’m using. Here’s what i have to do right now, this is ridiculous

const oldConsoleLog = console.log;
console.log = () => {};
import Agenda from 'agenda';
console.log = oldConsoleLog;

[jonnywyatt]

This is polluting our logs, could you change from 'error' to 'warning' please?

[ronenteva]

+1

[damienleroux]

+1

[dimd13]

+1

[Left47]

+1

[raabbajam]

+1

[nmaggioni]

+1

[aletorrado]

+1 !!!!

[ptitdje45]

+1

[rollrodrig]

Hi. i saw why this error is log.
When i load
moment.js
moment-timezone.min.js
moment-timezone-with-data.min
print the error.
Also with
moment.js
moment-timezone.min.js
moment-timezone-with-data.min.js
moment-timezone-with-data-2010-2020.min.js

To prevent the log error i only loaded
moment.js
moment-timezone-with-data.min.js

And now the error is gone.

Greetings.

[basicdays]

I think the problem is NPM 3's deduplication and moment-timezone's monkey patching of the moment package. I'd have to test this, but I think the following causes multiple different moment-timezone packages to attempt to monkey patch the same moment module.

my-project/
|- package.json
|- node_modules/
   |- moment/ (v2.6.0)
   |- moment-timezone/ (v0.5.1)
   |- do-stuff/
      |- package.json (can use the same moment version but a different moment-timezone)
      |- moment-timezone/ (v0.4.1)

So when do-stuff requires moment-timezone, it attempts to monkey patch the root moment package. And when moment-timezone is required in my-project, it attempts to monkey patch moment with a newer moment-timezone package even though the do-stuff library already monkey patched it with an older moment-timezone.

I'd have to think of some ways that could be done to solve this, but this isn't an easy fix. If the projects were merged, the problem would probably go away though...

[dilame]

This is just horrible.

├── [email protected] 
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected] 

my app just had broken because of this. I installed new package sails-hook-cron, that uses [email protected] , and other part of my application no longer able to call moment.tz.guess().
First i thought it is nodejs issue. But now i see its smth wrong with moment-timezone. Fix it, please.

[maggiepint]

The console.log has been removed and released 0.5.11

[nitrocode]

I just saw this from pm2-logrotate's error logs

Moment Timezone 0.5.14 was already loaded with data from 2017c

[Dushusir]

now,it's

Moment Timezone 0.5.14 was already loaded with data from 2017c.

what should i do?

load js: