Moment-timezone: Change year range for data file to 2013-2023

Created on 9 May 2018  路  8Comments  路  Source: moment/moment-timezone

Currently, there is a file moment-timezone-with-data-2012-2022.js for those who want a smaller data file with only currently relevant data. For 2018 this range should be changed to 2013-2023, as it is supposed to be "current year +/-5 years" (previous change on this was https://github.com/moment/moment-timezone/commit/83e81ef127cba403aefef553c954d1ab17ef4c02).

enhancement

Most helpful comment

@MatthewHerbst For example, in my project:

import Moment from "moment";
import MomentTZ from "moment-timezone/builds/moment-timezone-with-data-10-year-range";

Basically, the build contains the moment-timezone library _and_ the data for the date ranges, and can be substituted for the normal moment-timezone + data import.

More information can be found in the documentation: http://momentjs.com/timezone/docs/

All 8 comments

Hi @Schnark I have created a PR for this issue. But the build failed. Can someone please help me fix this build issue?

Referencing https://github.com/moment/moment-timezone/issues/363#issuecomment-235654248 , would it be possible to rename the file to something like "moment-timezone-with-data-truncated.js" so that the path doesn't need to continually change?

Thinking about this more, I believe the correct way to handle this is to do all of the following:

  • Keep publishing the 2012-2022 file. When we last changed from 2010-2020, a lot of folks were suddenly broken. Don't want to repeat that.

  • Start publishing multiple other files:

    • 2013-2023 - should have done this last year. My bad.
    • 2014-2024 - this is where we should be now.
    • 10-year-range - this should be always updated and floating (+/- 5 years). Most users can take this one and the path won't continually change.
    • 1970-2030 - this range is much smaller than the "full" data, and seems to be prefered way to handle #697 based on comments there.

I'll pick this up for the next release, coming shortly.

Actually, I see no reason to publish older year range files. We'll keep 2012-2022 intact, and add a 1970-2030 and a 5-year rolling file.

This is completed in version 0.5.24. Thanks.

@mj1856 how does one use the new smaller file (1970-2030)?

@MatthewHerbst For example, in my project:

import Moment from "moment";
import MomentTZ from "moment-timezone/builds/moment-timezone-with-data-10-year-range";

Basically, the build contains the moment-timezone library _and_ the data for the date ranges, and can be substituted for the normal moment-timezone + data import.

More information can be found in the documentation: http://momentjs.com/timezone/docs/

Thanks @andrewpanfelsherpa!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

GMeulendyks picture GMeulendyks  路  5Comments

nodesocket picture nodesocket  路  4Comments

rama41222 picture rama41222  路  3Comments

jsg2021 picture jsg2021  路  3Comments

im1dermike picture im1dermike  路  4Comments