Molecule: Integrate ansible review alongside ansible-lint

[wilmardo]

Issue Type

• Feature request

Desired Behaviour

As the title already states, to integratie ansible-review into Molecule. Is this something that fits into the vision of Molecule?
Since the author of both seems to make a clear distinction between the two, ansible-lint is purely syntax checking and ansible-review is more coding style enforcing (see this PR for example).
In my humble opinion ansible-review has it place in the molecule workflow since ansible-review does for Ansible what flake8 does for Python.
I am no hero in Python but I could try to make it work with the current ansible-lint as template but it might be an easy implementation for one of the current maintainers?

Thanks for the awesome project! Molecule makes Ansible development and testing a whole lot easier :thumbsup:

[retr0h]

I'll look into this. Thanks for the issue @wilmardo.

[retr0h]

I am having a hard figuring out exactly what ansible-review is, or rather a good name for it.

• ansible-lint isn't necessarily syntax checking. It states it is a
  Best practices checker for Ansible, and that description holds true.
• While ansible-review doesn't have a very good explanation of what it really is.

They seem to be solving the same problem, and until the author of ansible-review does a better job answering https://github.com/willthames/ansible-review/issues/31 I'm hesitant to implement this.

Honestly, it feels as though ansible-review should just replace ansible-lint as the provisioner's linter in Molecule.

[retr0h]

@wilmardo If you can supply a standards.py file with parity of existing ansible-lint standards, I would be willing to incorporate ansible-review.

[wilmardo]

@retr0h I will look into this, hopefully this week

[berendt]

Is this ansible-review project still active? PRs are hanging in the quote and it looks like nobody is working on the open issues.

[wilmardo]

• PR's are getting merged (last one was 25/01/2018): closed pulls
• The author seems to respond just fine (https://github.com/willthames/ansible-review/issues/50)
• Nobody is working on open issues is a problem across open source, it is easy to open an issue bit fixing them is another ballgame.

So no dead project indicators for me :)

PS. this issue isn't forgotten just haven't got time just yet

[retr0h]

@wilmardo sure just remember if we switch to ansible-review the rules file will need present the same rules as ansible-lint currently enforces. I really don't want users to get hounded with a ton of new linting issues simply by upgrading to a molecule which uses ansible-review vs ansible-lint.

If we can accomplish those things, I see no problem moving to ansible-review. However, since I am not implementing this feature, and I generally don't like issues lingering around here. This could get closed out if there isn't movement in the near future.

[greg-hellings]

It's worth noting that ansible-lint and ansible-review are both from the same author. He says, himself, in the above referenced issue that ansible-lint he now sees as being a library for ansible-review to use under the hood. Updating to ansible-review is probably worth a closer look and some effort.

[retr0h]

@greg-hellings sure, but I don't want to integrate ansible-review w/o a standards file on par with the current ansible-lint rules. People's roles would immediately have tons of linting issues, simply by moving to ansible-review.

So yes, ansible-review == good, but only if we get a standards file on par with ansibe-lint's existing rules.

[retr0h]

Closing as there is no indication this work will be done. When/if the time comes, we can reference this ticket.