Modernizr: FR: Detection for Array.prototype.includes()

[evanrmurphy]

I don't see any feature detection in Modernizr for Array.prototype.includes(). I would find this useful, would others?

Perhaps we could add this to the series of checks in es6/array.js, or is Array.prototype.includes() considered post-es6?

Modernizr is an excellent library - a staple of modern web development. Thanks for everyone who has worked to make it so great!

[rejas]

Would be nice to have something. Not sure if it is post-es6, will there every be an official es7?

[evanrmurphy]

Ok, I just confirmed that this is part of the es7 a.k.a. es2016 spec.

I could create a PR with a new file feature-detects/es7/array.js that basically just performs a check for Array.prototype.includes(). This would give us something for this and provide a place for other es7 checks to be layered on.

How does this sound?

[rejas]

Sounds good to me! PR are very welcome, but I have to point out that no new release will be coming until @patrickkettner shows up again....

[rejas]

HI @evanrmurphy since releases start flowing again, I wanted to ask if you are still interested in creating a PR for this?

[dabretin]

Hi !
Is this thread dead?

[rejas]

well @evanrmurphy didnt respond so maybe. do you want / need this feature?

[dabretin]

Ohhh yes,I need this feature :)
PR try made :)