Model-viewer: Poster coverage is not seamless when aspect ratio is "more portrait" than generated poster

[hybridherbst]

Description

Follow up to #1428.

Poster coverage is not seamless at portrait aspect ratios. Seems the poster is scaled down to fit into viewport while the model is not scaled down, resulting in incorrect transition.

Live Demo

http://modelviewer.dev/editor

Create & display poster at ~square aspect
Scale page to "portrait" (e.g. 1:2)
Click on poster
Expected: seamless transition
Actual: different fit

Browser Affected

• [X] Chrome
• [ ] Edge
• [ ] Firefox
• [ ] IE
• [X] Safari

OS

• [X] Android
• [X] iOS
• [ ] Linux
• [ ] MacOS
• [X] Windows

[elalish]

Ah yes, this is a quirk specific to the editor. It will work properly in a model-viewer element at least. I need to handle the camera updates better. FYI @stevesan

[hybridherbst]

I see, should have tested better – so the issue is actually that the editor does not scale the camera aspect as it does in model-viewer when resizing?

[elalish]

Yeah, basically the problem is that it keeps its own state; I need to make it use model-viewer's camera state instead.

[elalish]

This was fixed a few months ago and we forgot to close the issue.