Model-viewer: HDR Environment not lighting models on Samsung Galaxy S8 or S9

[pushmatrix]

Description

Currently testing viewing a PBR model on a Samsung Galaxy S8 and S9 and am running into an issue where it appears unlit.

I have stage lighting set to 0, and if I turn stage lighting back on, then you do see it lit:

Caveat: I am testing this in Browserstack since I don't have an actual S8 or S9, however browserstack is just a video feed from real devices. It works on an S10.

I get the following in console:

Live Demo

https://obtainable-pancake-1.glitch.me/

OS & Browser Affected

Versions

• model-viewer: v0.3.1
• three.js: r101

[cdata]

Thanks for filing this @pushmatrix . What is that tool that you are using to test those devices?

Is this a dupe of #574 ?

cc @elalish

[elalish]

I was guessing it was a dupe of #601. Does turning on PMREM fix it?

[elalish]

Nevermind, I bet @cdata is right. Our environment map generation uses half float textures, and when that's not supported, everything down stream of that will fail. OES_texture_float_linear and EXT_shader_texture_lod are pretty critical to us now. We might want to decide if we should build an IBL system that doesn't rely on these extensions.

[pushmatrix]

@cdata I use Browserstack:

Amazing tool. It spins up actual devices and lets you remotely control them from the web. You even have access to DevTools on them.

[cdata]

That is amazing 😍 gonna purge Sauce Labs with fire now...

[elalish]

Closed via #591

[elalish]

@pushmatrix I'm pretty confident this is fixed, but I don't have the right device to test the repro. Can you check and let me know if this problem persists?

[pushmatrix]

@elalish Just tested on an S8 and confirm it works correctly. Thanks for the fix!