Mobx: Mobx 4.9.1 breaks IE11 compatibility

[Havunen]

Code in question:

    ObservableSet$$1.prototype[Symbol.iterator] = function () {
        return this.values();
    };

Error:
Symbol' is undefined

[Havunen]

Mobx 4.8.0 works as expected

[nykula]

Can confirm, this assignment in observableset.ts should check typeof Symbol like observablearray.ts. Personally I polyfill anyway because of array helpers and Fetch API etc, but MobX already has the fallback in a few places so for consistency it can be moved to a constant. @mweststrate please respond whether I should make a pull request or you meant to start removing the fallbacks.

[Havunen]

Mobx v4 is documented to be ES5 complaint. So this must be bug

[mweststrate]

Yes this is a bug as and a result of backporting Set. Symbol should be
polyfilled in observableset exactly the same as in obseevablemap.

Op wo 23 jan. 2019 18:37 schreef Sampo Kivistö [e-mail]:

Mobx v4 is documented to be ES5 complaint. So this must be bug

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx/issues/1878#issuecomment-456896016, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABvGhGacck8jfodiTWfN_tw-4y41k9TSks5vGJ30gaJpZM4aOktT
.

[mweststrate]

@makepost @Havunen should be fixed in 4.9.2. Please let me know if it isn't! (No IE 11 available atm, so couldn't fully reproduce it)

[Havunen]

Now it failed to Set is undefined

[Havunen]

Travis Logs:
https://travis-ci.org/infernojs/inferno/jobs/484400988

[mweststrate]

Curious, how did you automate IE tests? We could use that 😊

Op vr 25 jan. 2019 16:37 schreef Sampo Kivistö [e-mail]:

Travis Logs:
https://travis-ci.org/infernojs/inferno/jobs/484400988

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx/issues/1878#issuecomment-457612833, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABvGhNbbYjBNW51xzGsTrOElRVaP4p6Jks5vGySqgaJpZM4aOktT
.

[mweststrate]

The test that failed, does it use Sets?

Op vr 25 jan. 2019 22:26 schreef Michel Weststrate [e-mail]:

Curious, how did you automate IE tests? We could use that 😊

Op vr 25 jan. 2019 16:37 schreef Sampo Kivistö [e-mail]:

Travis Logs:
https://travis-ci.org/infernojs/inferno/jobs/484400988

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx/issues/1878#issuecomment-457612833, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABvGhNbbYjBNW51xzGsTrOElRVaP4p6Jks5vGySqgaJpZM4aOktT
.

[davojan]

Updating to 4.9.2 has broken my webpack build with typescript error:

ERROR in node_modules/mobx/lib/types/observablemap.d.ts(42,5):
TS2416: Property '[Symbol.toStringTag]' in type 'ObservableMap<K, V>' is not assignable to the same property in base type 'Map<K, V>'.
  Type 'string' is not assignable to type '"Map"'.

Reverting to 4.9.1 fixes this.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.