Mjml: Documentation (default padding for mj-column and default padding for mj-social-element)

Created on 18 Jun 2019  路  5Comments  路  Source: mjmlio/mjml

Both default padding in the documentation are wrong (should be n/a for column and 4px for mj-social-element)

Documentation

Most helpful comment

Website is still updated manually, it's holiday season dunno when they will have time to update the doc to 4.4.1 release. I'm closing then

All 5 comments

Can you open a PR on that please ? So we could fix it for 4.4 ? thanks

Hello!
It looks like this kind of got left in the dust; Do you mind if I open a PR to fix this in the docs @iRyusa ?

Ofc yep

Just forked and it seems like this was already addressed and fixed in PR #1631 by @kevingermain

That said, it appears those changes aren't being reflected on the docs website yet. See the mj-column and mj-social docs pages. Strange. I'm assuming that will be updated at some point with a new release.

Either way, I'm glad someone caught the issue and submitted a fix!

Website is still updated manually, it's holiday season dunno when they will have time to update the doc to 4.4.1 release. I'm closing then

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zarikadzer picture zarikadzer  路  3Comments

csmcanarney picture csmcanarney  路  3Comments

valstu picture valstu  路  3Comments

liminspace picture liminspace  路  3Comments

samatcd picture samatcd  路  4Comments