Mjml: Remove default inline font-size:13px set on mj-columns

[viktorix]

Describe the bug
By default, mj-column gets inline font-size:13px set but since font-size isn't available for mj-column it can't be deleted/overwritten. Any specific reason for this?

To Reproduce
Steps to reproduce the behavior:

1. Create simple MJML template with mj-column
2. Copy HTML
3. Check inline styles of column DIVs

Expected behavior
Either mj-column shouldn't have font-size set by default or allow font-size attribute for mj-column.

MJML environment (please complete the following information):

• OS: Win 10
• MJML 4.3.1
• MJML App 2.11.0
  
  
  
  • this also happens in Visual Studio Code with MJML extension.
  
  

Thanks.

[iRyusa]

Well that one is really weird as it should be font-size:0; instead, let's
fix this for 4.4

On Sun, Mar 31, 2019 at 8:38 AM Viktor Nagornyy [e-mail]
wrote:

Describe the bug
By default, mj-column gets inline font-size:13px set but since font-size
isn't available for mj-column it can't be deleted/overwritten. Any specific
reason for this?

To Reproduce
Steps to reproduce the behavior:

1. Create simple MJML template with mj-column
2. Copy HTML
3. Check inline styles of column DIVs

Expected behavior
Either mj-column shouldn't have font-size set by default or allow
font-size attribute for mj-column.

MJML environment (please complete the following information):

• OS: Win 10
• MJML 4.3.1
• MJML App 2.11.0
• this also happens in Visual Studio Code with MJML extension.

Thanks.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mjmlio/mjml/issues/1560, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAizzY1M8R5VGtX8QMlcgg1XmY-3TmNnks5vcFfNgaJpZM4cUJgJ
.

[YasiOnFire]

1563

I think this kinda breaks mj-raw, or am i mistaken? Should one expect to explicitly set font-size in the raw html code to overwrite font-size 0 from mj-column? (testing on MJML 4.4.0-beta.2)

[iRyusa]

Dunno if "break" is the best word for this, but yeah it will change the behavior of it.

You would just need to add font-size on content inside mj-raw as it's done already in any content tag in mjml so it's just about following best practice ? Most of mj-raw are related to templating stuff so it shouldn't be a real issue here.

We'll add a warning on the changelog about this anyway

[Snowirbix]

Of course it breaks mj-raw, can we add a comment on https://mjml.io/documentation/#mj-raw ?