Mixedrealitytoolkit-unity: UPM: Upgrading shaders for Universal Render Pipeline does not persist
Describe the bug
When MRTK is installed via UPM upgrading the MRTK Standard shader for Universal RP will only update materials for the current sessoin. Once Unity is restarted the shader/materials are back to the legacy mode.
To reproduce
- Import MRTK via UPM
- Upgrade shaders/materials
- Restart Unity
- Materials are not working with URP again
Expected behavior
The upgrade persists.
Your setup (please complete the following information)
- Unity 2019.4 LTS
- MRTK 2.5
- Import via UPM
FejZa
All 5 comments
Got it too!
Kent1LG
on 11 Oct 2020
Ahh @Cameron-Micka, does this step edit the shader file directly?
@davidkline-ms might be another asset we'll need to import into the Assets folder.
keveleigh
on 12 Oct 2020
@keveleigh yes it does! It changes two lines in the shader: https://github.com/microsoft/MixedRealityToolkit-Unity/blob/06a06778e38da622b37cc299a93f16e143b7bdeb/Assets/MRTK/Core/Inspectors/MixedRealityStandardShaderGUI.cs#L781
Cameron-Micka
on 12 Oct 2020
@keveleigh @Cameron-Micka thanks for the info.
I would love to not require importing unless the customer needs to update to URP. Any thoughts on how to do that given the constraints of UPM?
davidkline-ms
on 13 Oct 2020
fixed with #8804
davidkline-ms
on 20 Oct 2020
Related issues
reillydonovan
路
3Comments
dustin2711
路
3Comments
chrisfromwork
路
3Comments
provencher
路
3Comments
nrchuanqi
路
3Comments
Most helpful comment
Ahh @Cameron-Micka, does this step edit the shader file directly?
@davidkline-ms might be another asset we'll need to import into the Assets folder.