Mithril.js: [rewrite] Promise - console.error: Possible unhandled promise rejection

[simov]

Hi,

I get this weird error message in my console and I don't know what to do with it. Here is how to reproduce it:

server.js

var http = require('http')
var server = http.createServer()
server.on('request', (req, res) => {
  res.writeHead(400, {
    'Access-Control-Allow-Origin': '*',
    'content-type': 'text/plain'
  })
  res.end('hi')
})
server.listen(3000)

client.html

<script>
  m.request({
    method: 'GET',
    url: 'http://localhost:3000'
  })
  .then(() => console.log('OK'))
  .catch((err) => console.log(err.message, 'totally not OK'))
</script>

output

As you can see I'm making HTTP request to a server that responds with a 400 status code. Then I'm handling the error in the catch error handler by printing it out to the console, and yet I'm still getting the console.error message on line 101 - Possible unhandled promise rejection. I'm not sure what to do with this error message.

[isiahmeadows]

What version is this?

[simov]

Latest rewirte branch from a few hours ago.

[isiahmeadows]

Here's the problem section. Should be easy to fix, even for those less familiar with the rewrite code base.

[lhorie]

@isiahmeadows if it's easy, you could go ahead and do it (just sayin') :)

[lhorie]

Fixed

[simov]

Thanks to everyone involved :+1:

[isiahmeadows]

@lhorie I was kind of leaving it hanging in hopes for a potential new contributor. :wink: