Misp: [Bug][Kinda important] Can't add new tags

[Res260]

So we just upgraded to the latest version of MISP and we can't create tags anymore. I'm looking into the problem atm.

Work environment

| Questions | Answers
|---------------------------|--------------------
| Type of issue | Bug
| OS version (server) | Ubuntu
| OS version (client) | 16.04
| PHP version | 7.0
| MISP version / git hash | 2.4.88, https://github.com/MISP/MISP/commit/f44628c31f19de8080c07f3daeb9a34265be5761
| Browser | Chrome/FF/IE

Expected behavior

The tag is saved.

Actual behavior

Steps to reproduce the behavior

1. Go to add tag
2. Populate name, color
3. Submit

EDIT: Tested on our production instance and on my local instance.

[Res260]

So when removing this rule, it works:

[Res260]

@iglocska You added this rule 2 days ago in this commit, did it work for you? https://github.com/MISP/MISP/commit/b2f0787d15bf6af9976d2d9355486c31b9fef483

[Res260]

Found a fix, opening a pull request

[adulau]

Strange, it worked for me on the HEAD.

[Res260]

This would be my change:

This is strange that it works for you. Right now, with notBlank, I get the expected behaviour...

[Res260]

Ok I read a bit on required, it seems it only applies to other rules as seen here:

https://book.cakephp.org/2.0/en/models/data-validation.html#required

So putting only 'required' => true should not work, it needs to come with another rule, such as notBlank.

[iglocska]

Indeed, good catch! Surprised that this went under the radar.

[adulau]

Good catch! Still don't know why it wasn't reproducible on recent versions. Thank you.

[iglocska]

it's very new, introduced 1-2 days ago afaik

[Res260]

Np, so if we run the update again on our production instance, it should fix the issue?

[iglocska]

yeah, git pull and it should work

[Res260]

Alright thanks for the fast response. And well we went from MISP 2.4.82 to MISP 2.4.88, and now I can add tags (I couldnt before, permission-wise), is that a normal behavior with the new version?

[iglocska]

what does your role say?

[Res260]

[iglocska]

Yes, you should be able to add tags!