Minimal-mistakes: Author object tags showing at top of page
I know this must mean I've done something silly but I can't see what it is.
When I build the site it displays as follows:
Any hints as to what I've done?
padraic7a
All 23 comments
Not exactly sure but all those variables are author ones in _config.yml. Maybe you have some improperly formatted YAML there.
mmistakes
on 27 Apr 2016
That must be it. Thanks for your time and the theme.
padraic7a
on 27 Apr 2016
I think you found a bug.
In _config.yml. Quick fix is to add a Twitter account under author
author:
twitter: "padraicst"
There's a conditional in the <head> that I need to improve. It's getting confused by the fact that you set site twitter.username but not author.twitter as well.
mmistakes
on 27 Apr 2016
Bug fix, change *_includes/seo.html line 28
{% assign seo_author = page.author | default: page.author[0] | default: site.author[0] %}
Ah, I was just drafting a response saying that it only triggers with a twitter username. I thought it might be because I put some extra gems in the gemfile.
Thanks again for your help!
padraic7a
on 27 Apr 2016
I have a related bug. I was using the Jekyll Wordpress importer tool and it creates the front matter yaml:
author:
display_name: Someone
login: someone
email: [email protected]
url: ''
As a result I get this:
I traced the error to this line:
https://github.com/mmistakes/minimal-mistakes/blob/master/_includes/seo.html#L42
Any ideas?
I am using this theme as a remote_theme in the _config.yml
viktorsmari
on 8 Jan 2018
@viktorsmari The theme expects author to be a string not an array, that's why it's outputted that garbage at the top of your posts.
This is the way the theme expects post author's to be specified.
mmistakes
on 8 Jan 2018
Thank you.
Because I was migrating a Wordpress site with hundreds of posts with the same front matter format, where the author is an array. Do I need to change each post or is there a simpler way?
I am trying not to mess with the theme defaults.
viktorsmari
on 8 Jan 2018
@viktorsmari I don't think there is an easy way forward. I'll take a look at the templates and see if there is something I can adjust. jekyll/feed and jekyll/jekyll-seo-tag both use author in a similar way as this theme. I'll take a look and see what their solution is to accept author as a string or object.
mmistakes
on 8 Jan 2018
@viktorsmari I pushed some updates. Try changing remote_theme to the fix branch and see if that takes care of the issue.
remote_theme: "mmistakes/minimal-mistakes@seo-fixes"
mmistakes
on 8 Jan 2018
Hmm does not seem to work, if you want to try it yourself it is an open source project:
https://github.com/piratar/piratar-jekyll
Remember to remove the _includes/seo.html, or uncomment line ~42.
I start the project with the ./server.sh
viktorsmari
on 8 Jan 2018
@viktorsmari Quick look you didn't update remote_theme in your _config.yml. You need to use the line above so it pulls from the git branch with the fix. Otherwise it'll continue to use the current version on master.
remote_theme: "mmistakes/minimal-mistakes@seo-fixes"
I tried that locally, which did not work. I just did not push this change to Github.
viktorsmari
on 8 Jan 2018
@viktorsmari Hmmm. Define not working. I'm not seeing the author object array text on any of your pages like before.
mmistakes
on 8 Jan 2018
If you scroll at the bottom of the frontpage, there are many pages you can try.
Like the last one "Styrkja Pirata", does that one work?
Did you also undo/uncomment the SEO I wrote above?
viktorsmari
on 8 Jan 2018
@viktorsmari Yup. I removed your local version of _includes/seo.html so it doesn't override the fixed one in the theme.
All the pages, including that last one work as expected. No erroneous text printing on the pages from author.
mmistakes
on 8 Jan 2018
Weird, this is my setup:
viktorsmari
on 8 Jan 2018
@padraic7a And you deleted your copy of _includes/seo.html?
mmistakes
on 8 Jan 2018
Haha, that was it!
Thank you for your patience!
viktorsmari
on 8 Jan 2018
@viktorsmari OK good.
FYI - When I merge in this change you'll want to remove @seo-fixes from the remote theme line. It can pull from master at that point since that SEO branch will eventually be deleted.
mmistakes
on 8 Jan 2018
Hi @mmistakes , I haven't updated or even looked at the site since April 2016. I'll check this thread out when I get to update again.
Do you need me to close this issue?
padraic7a
on 8 Jan 2018
Nah don't worry about it @padraic7a, I reopened it today to deal with a sort of related issue.
It'll close automatically when I merge in the fix https://github.com/mmistakes/minimal-mistakes/commit/176261c88e7afc9594e8efcdf2f453f34741966c
A lot has changed with the theme since then, if/when you get around to updating give the docs a look. It's much easier to install/upgrade the theme once you migrate.
mmistakes
on 8 Jan 2018
Great, will do. Thanks!
On 8 January 2018 at 17:06, Michael Rose notifications@github.com wrote:
Nah don't worry about it @padraic7a https://github.com/padraic7a, I
reopened it today to deal with a sort of related issue.It'll close automatically when I merge in the fix 176261c
https://github.com/mmistakes/minimal-mistakes/commit/176261c88e7afc9594e8efcdf2f453f34741966cA lot has changed with the theme since then, if/when you get around to
updating give the docs a look
https://mmistakes.github.io/minimal-mistakes/docs/upgrading/. It's much
easier to install/upgrade the theme once you migrate.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mmistakes/minimal-mistakes/issues/289#issuecomment-356028803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC3vV6FL0Xpg02zB5WhheGZn6KJz68BEks5tIksYgaJpZM4IQ2W_
.
padraic7a
on 8 Jan 2018
Related issues
satwikkansal
·
4Comments
m1evankaiser
·
3Comments
halirutan
·
4Comments
wilsonmar
·
3Comments
ashleyconnor
·
4Comments