Minikube: Use configured DNS domain in bootstrapper kubeadm templates

[Eelis]

The following two lines specify cluster.local, but if minikube was started with --dns-domain bla, that domain should probably be used instead.

https://github.com/kubernetes/minikube/blob/ae9f406b3852802b14c6b797a51d41eedd6d85b1/pkg/minikube/bootstrapper/kubeadm/templates.go#L87

https://github.com/kubernetes/minikube/blob/ae9f406b3852802b14c6b797a51d41eedd6d85b1/pkg/minikube/bootstrapper/kubeadm/templates.go#L141

[Eelis]

The effect of this bug is that networking/dnsDomain in the ClusterConfiguration entry in the kubeadm-config ConfigMap is set incorrectly (when minikube is started with --dns-domain bla).

[bhanu-lab]

/assign

[medyagh]

@bhanu011 are you still working on this ?

[bhanu-lab]

@medyagh yes.

[tstromberg]

Excellent! Please let me know if there is anything I could help with.

[tstromberg]

Hey @bhanu011 - Just checking in to see if you are planning to land this PR soon, and/or if you need any help to implement or test this.

[tstromberg]

@bhanu011 - Will this be ready in time for the v1.4.0 release on Sep 16?

[tstromberg]

Any update?

[nanikjava]

@tstromberg @bhanu011 is this ticket being worked on ? happy to take and run with this. Thanks

[medyagh]

@nanikjava it is yours ! please let me know if you need any help

@bhanu011 since I didn't hear from you, I have assigned this issue to someone else

[nanikjava]

Thanks @medyagh

[nanikjava]

Check on /var/tmp/minikube/kubeadm.yaml inside minikube using ssh for testing the the --dns-domain flag

without using the flag

apiVersion: kubeadm.k8s.io/v1beta1
kind: InitConfiguration
localAPIEndpoint:
......

......

apiVersion: kubeadm.k8s.io/v1beta1
kind: ClusterConfiguration
.....
.....
kubernetesVersion: v1.16.0
networking:
dnsDomain: cluster.local
podSubnet: ""

serviceSubnet: 10.96.0.0/12

with the flag --dns-domain bla.blah.blah

apiVersion: kubeadm.k8s.io/v1beta1
kind: InitConfiguration
localAPIEndpoint:
......

......

apiVersion: kubeadm.k8s.io/v1beta1
kind: ClusterConfiguration
.....
.....
kubernetesVersion: v1.16.0
networking:
dnsDomain: bla.blah.blah
podSubnet: ""

serviceSubnet: 10.96.0.0/12

[nanikjava]

@medyagh Pull request submitted https://github.com/kubernetes/minikube/pull/5566

[Eelis]

Awesome, thanks @nanikjava! This fix makes my life a lot easier. :)