Minikube: `minikube delete` with --vm-driver=none leaves running containers

[drigz]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Environment:

Minikube version: v0.25.0

• OS: Ubuntu 14.04
• VM Driver: none
• ISO version: n/a

What happened:

Containers still running or present after minikube delete.

What you expected to happen:

Containers stopped/killed and deleted.

How to reproduce it (as minimally and precisely as possible):

minikube config set vm-driver none
minikube start
# optionally: minikube stop
minikube delete
docker ps -a

Anything else do we need to know:

Based on a brief investigation, there are two cases:

without minikube stop:
The containers are running. However, Remove() doesn't kill localkube, so when the containers are killed and removed, localkube brings them back up.

This could be fixed by killing localkube in Remove().

with minikube stop:
Because the containers are stopped, docker kill doesn't kill them. Remove() passes the output of docker kill into docker rm, but this doesn't include already-stopped containers.

This could be fixed by using docker rm -f $(docker ps ...) instead of docker rm $(docker kill $(docker ps ...)).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[aojea]

I solved a similar issue running sudo kubeadm reset

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close