Minify: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()

[INRIX-Xiaodi-Huang]

ERROR in unknown: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()

Seems to be the result of this change :
https://github.com/babel/babili/pull/543/files

[boopathi]

Thanks. Do you have a small snippet as input to reproduce this ?

[INRIX-Xiaodi-Huang]

Our codebase is pretty large. I am not sure what caused this error when minifying. I was using the babili webpack plugin with the following options.

(isProdFlavor = true);

new BabiliPlugin({
  booleans: isProdFlavor,
  builtIns: isProdFlavor,
  consecutiveAdds: isProdFlavor,
  flipComparisons: isProdFlavor,
  infinity: isProdFlavor,
   mangle: isProdFlavor,
   memberExpressions: isProdFlavor,
  mergeVars: isProdFlavor,
  numericLiterals: isProdFlavor,
  propertyLiterals: isProdFlavor,
  regexpConstructors: false,
  removeUndefined: isProdFlavor,
  replace: isProdFlavor,
   simplify: isProdFlavor,
  simplifyComparisons: isProdFlavor,
   typeConstructors: isProdFlavor,
  undefinedToVoid: isProdFlavor
 })

[MDendura]

@INRIX-Xiaodi-Huang I've had the same error when updating babili-webpack-plugin from 0.0.11 to 0.1.1. Are you using that too?

[arthurmchr]

Using babili version 0.1.3 I got the error

[boopathi]

Can you share the stack trace ?

[arthurmchr]

Error: /Users/arthur/Documents/jean/gabrielle.js: Don't use `path.replaceWith()` with a source string, use `path.replaceWithSourceString()`
    at NodePath.replaceWith (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/replacement.js:139:11)
    at swap (/Users/arthur/Documents/jean/node_modules/babel-plugin-minify-constant-folding/lib/index.js:42:10)
    at PluginPass.CallExpression (/Users/arthur/Documents/jean/node_modules/babel-plugin-minify-constant-folding/lib/index.js:171:16)
    at newFn (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/path/context.js:105:12)
    at TraversalContext.visitQueue (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitSingle (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:108:19)
    at TraversalContext.visit (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/context.js:192:19)
    at Function.traverse.node (/Users/arthur/Documents/jean/node_modules/babel-traverse/lib/index.js:114:17)

[damianobarbati]

same here! +1

[boopathi]

/cc @j-f1 Do you know why this happens in the swap function ?

https://github.com/babel/babili/blob/7e2b315e37fc6392dbe05acf9463520d05434f56/packages/babel-plugin-minify-constant-folding/src/index.js#L34

[j-f1]

@boopathi I have no idea. It appears that all of the methods used return nodes. Can anyone provide an example snippet that fails?

[michaeltrim]

+1

[j-f1]

@michaeltrim Can you provide an example code snippet that fails?

[johnryan]

@j-f1 Any suggestions for how to figure out what line of code is failing? There's not much in the stack trace so finding the failing chunk of code seems pretty impossible in a large project.

[damianobarbati]

guys I have no way to provide snippets for the fail :(

[michaeltrim]

Not sure how to provide a code snippet that fails.

I get the Error:

ERROR in unknown: Don't use path.replaceWith() with a source string, use path.replaceWithSourceString()

when I run yarn run build-main and do a stack trace before the error is thrown I get the following, not sure if that helps:

at NodePath.replaceWith (/myapp/node_modules/babel-traverse/lib/path/replacement.js:140:13)
at swap (/myapp/node_modules/babel-plugin-minify-constant-folding/lib/index.js:42:10)
at PluginPass.CallExpression (/myapp/node_modules/babel-plugin-minify-constant-folding/lib/index.js:171:16)
at newFn (/myapp/node_modules/babel-traverse/lib/visitors.js:276:21)
at NodePath._call (/myapp/node_modules/babel-traverse/lib/path/context.js:76:18)
at NodePath.call (/myapp/node_modules/babel-traverse/lib/path/context.js:48:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:105:12)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitMultiple (/myapp/node_modules/babel-traverse/lib/context.js:103:17)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:190:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitSingle (/myapp/node_modules/babel-traverse/lib/context.js:108:19)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:192:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)
at NodePath.visit (/myapp/node_modules/babel-traverse/lib/path/context.js:115:19)
at TraversalContext.visitQueue (/myapp/node_modules/babel-traverse/lib/context.js:150:16)
at TraversalContext.visitMultiple (/myapp/node_modules/babel-traverse/lib/context.js:103:17)
at TraversalContext.visit (/myapp/node_modules/babel-traverse/lib/context.js:190:19)
at Function.traverse.node (/myapp/node_modules/babel-traverse/lib/index.js:114:17)

[michaeltrim]

I can see that the method path.replaceWith() is getting passed a string of "[object Object]"

[j-f1]

@michaeltrim Can you try replacing node_modules/babel-plugin-minify-constant-folding/lib/index.js with this patched version to see if that fixes it?

[michaeltrim]

@j-f1 That has fixed the error when running yarn run build-main, thank you.

yarn run package still doesn't complete but this may be unrelated just doing some investigation and will let you know.

[michaeltrim]

Believe memory issue related to https://github.com/babel/babili/issues/332

[frzi]

@j-f1 This patch fixed the issue for me as well. Thanks!

[damianobarbati]

@j-f1 is a patch about to be release soon?

[j-f1]

I was just checking to see if that fixed the problem. The PR above includes that fix.

[Xazzzi-CT]

Is this on npm yet? Asking because i still get this error message.

[MikeLP]

It's really urgent.

[ahumphreys87]

I've downgraded to 0.0.11 while waiting. If it's breaking production builds
then you could do the same.

I think they said it would be released this afternoon. If downgrading is
too much trouble

On Mon, 19 Jun 2017 at 17:53 Yan Zhabin [e-mail] wrote:

It's really urgent.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/babel/babili/issues/576#issuecomment-309500685, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACZOuC1MLhDyJN2KYoUMjrl_CWsA_3eZks5sFqeigaJpZM4N43b0
.

[damianobarbati]

Just tried the 0.1.1 and it's broken as well 😱

[ahumphreys87]

0.0.11
On Tue, 20 Jun 2017 at 08:47 damiano.barbati [e-mail]
wrote:

Just tried the 0.1.1 and it's broken as well 😱

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
https://github.com/babel/babili/issues/576#issuecomment-309672665, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACZOuCoAIe9kCjYj5pI7dMfi3ArDA63bks5sF3ksgaJpZM4N43b0
.

[damianobarbati]

@ahumphreys87 yep, using that for now thanks!

[ahumphreys87]

Awesome, fingers crossed the fix version won't be long
On Tue, 20 Jun 2017 at 08:56 damiano.barbati [e-mail]
wrote:

@ahumphreys87 https://github.com/ahumphreys87 yep, using that for now
thanks!

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/babel/babili/issues/576#issuecomment-309674539, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACZOuHzVhlXtNe8VBbMX3-0JgZNhO0xiks5sF3sXgaJpZM4N43b0
.

[vigneshshanmugam]

New version is released now with this fix https://github.com/babel/babili/releases/tag/babili%400.1.4

[LeeeeeeM]

problems with babel-traverse...em...