Mini-media-player: Enabling "group" and "show_progress" together looks bad

Created on 14 Jan 2019  路  3Comments  路  Source: kalkih/mini-media-player

Enabling "group" and "show_progress" together leaves no padding/margin between the secondary info and the progress bar, doesn't look good.

enhancement

Most helpful comment

Okay, so I ended up making the progressbar slightly slimmer (only when group: true) so the vertical height of the card wouldn't need to be increased more than necessary.
I'm not 100% satisfied so might change again in the future.

hyperion_8123_lovelace_4

All 3 comments

Thanks for reporting this, that does indeed look bad 馃あ

This is mostly an issue when the player is displayed in the "collapsed view" if I'm correct.

I'll most likely end up adding some paddings to the top and bottom of the card when group is set to true. It would make the card take up slightly more vertical space, but should look way better.

| Before | After |
| ------- | ------ |
| hyperion_8123_lovelace_4 1 | hyperion_8123_lovelace_4 2 |

Okay, so I ended up making the progressbar slightly slimmer (only when group: true) so the vertical height of the card wouldn't need to be increased more than necessary.
I'm not 100% satisfied so might change again in the future.

hyperion_8123_lovelace_4

Fix for this is now available in v1.0.0.
Thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

bramkragten picture bramkragten  路  4Comments

Krocko picture Krocko  路  4Comments

TheRealBadRobot picture TheRealBadRobot  路  3Comments

fleXible picture fleXible  路  5Comments

porebas picture porebas  路  5Comments