Minetest_game: Papyrus tops

Created on 18 Feb 2020  Â·  20Comments  Â·  Source: minetest/minetest_game

Since in real life papyrus looks like this: hi

I think at least the fuzzy top should be added.
Screenshot_2020-02-17-15-02-08-1

papyrus_top

Request / Suggestion Supported by core dev

Most helpful comment

I'm willing to do a PR if nobody else wants to

All 20 comments

This has occurred to me too.
However, i expect this is too disruptive to change now, considering papyrus farming machines in worlds etc.
Also ... all the existing papyrus that will not change, and the growing code needing to cope with both situations.
Although they look 'wrong', i like the classic appearence.
I am thinking it is ~probably~ possibly best to leave them as they are.

I love the new papyrus. It's like being in old Egypt! :-)

I like this graphical change as well.

I like the look of it

I love it... even if it was just an addon mod to minetest... I know a lot and a lot of people would use it

I wondered why similar issues don't come up more often.

It would be possible to change the plantlike rendering code to allow different a texture for the (bottom or) top-most node of the plant. Not sure in how many situations this will be useful though.

@sfan5 that would cool if we could do that for plantlike rooted. Give kelp a top and bottom.

P.S. Hi @Gerold55 long time no see!

Hey yeah it's been a while...

On Tue, Feb 18, 2020, 13:12 Extex101 notifications@github.com wrote:

@sfan5 https://github.com/sfan5 that would cool if we could do that for
plantlike rooted. Give kelp a top and bottom.

P.S. Hi @Gerold55 https://github.com/Gerold55 long time no see!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/minetest/minetest_game/issues/2601?email_source=notifications&email_token=ADJTVF54T7YV44RW6QCKWJLRDQQKPA5CNFSM4KW2A7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDA4DY#issuecomment-587599375,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJTVF5XMETAAMUWSZAXS5DRDQQKPANCNFSM4KW2A7PQ
.

To be clear, i think this could 'look' good, but it is important to think through all the issues.
Papyrus has been this way for many years, people build automated machines for farming papyrus that assume no special top node, a change could break many worlds, so we have to be careful.
I do not currently disapprove, just unsure it is worth doing. I should have used the word 'possibly' instead of 'probably' in the first post.

I think the texture would need to be improved, as you can see it does not resemble the photograph, needs to be taller and more spherical.

-1 for changes to plantlike drawtypes for a special 'top', i cannot see enough need currently and this can be done in MTG. Changes to drawtypes need a lot of justification.
Kelp looks fine as it is.

Servers that have machines that farm papyrus break it from the bottom. So that won't be a problem

Really MT papyrus isn't realistic at all. Since it has like the little bumby things like bamboo. bamboo And papyrus is smooth and straight &

The appearance of papyrus in minetest is a ripoff of MC sugarcane ¡

Yes and it would only change the bottom mostly no need to change the block
name. The top piece when broken would be a regular papyrus...

On Tue, Feb 18, 2020, 17:31 Extex101 notifications@github.com wrote:

Servers that have machines that farm papyrus break it from the bottom. So
that won't be a problem

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/minetest/minetest_game/issues/2601?email_source=notifications&email_token=ADJTVF4UOEIRRU22Z7O6EJTRDROVPA5CNFSM4KW2A7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMFTL7Y#issuecomment-587937279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJTVFYWYMQK5TPUC7VA4RTRDROVPANCNFSM4KW2A7PQ
.

Yeah just have it drop normal papyrus

-1 for changes to plantlike drawtypes for a special 'top', i cannot see enough need currently and this can be done in MTG. Changes to drawtypes need a lot of justification.

You are saying "this can be done in MTG", yet you argue that we can't change the top node because people might rely on it. Yes, drawtypes should not just be changed because it's convenient but this would solve exactly this issue.

people build automated machines for farming papyrus that assume no special top node, a change could break many worlds, so we have to be careful.

I agree that care should be taken not to break worlds.
However I don't think we should cater to automatic farming or similar things and try to ensure such contraptions never ever break. Changes are fine as long as automated farming is not made entirely impossible.

Why not follow the developers method in these case: making a new papyrus node which is more realistic and mark the old one deprecated, so players are invited to not use it anymore ? (may be you can add a visual effect to depracted nodes).

:+1: Looks awesome! Can't wait for a PR

I think the new top bit shouldn't count as papyrus; instead be just a design, where it doesn't drop anything. Of course, it should be removed after one has dug the papyrus.

I'm willing to do a PR if nobody else wants to

Look forward to seeing it...

On Thu, Feb 20, 2020, 10:00 LoneWolfHT notifications@github.com wrote:

I'm willing to do a PR if nobody else wants to

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/minetest/minetest_game/issues/2601?email_source=notifications&email_token=ADJTVF3BWTVT3AUDJFSJLETRD2LIFA5CNFSM4KW2A7P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMONVBI#issuecomment-589093509,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJTVFYZJTZDXMIKKJIARRLRD2LIFANCNFSM4KW2A7PQ
.

This adds a nice visual, I like it.
And papyrus should really have more varieties of uses in-game (but that is a topic elsewhere)
https://egypt.mrdonn.org/papyrus.html

Screenshot from 2020-02-24 01-42-08

https://extension.msstate.edu/sites/default/files/news/2018/sg20180514_king_tut.JPG

Servers that have machines that farm papyrus break it from the bottom. So that won't be a problem

Thanks for the information, so i have no objection to this done using an additional node added to the top. The texture needs to be improved and be more of a 'spherical puff', and an updated stem texture would be good to remove the ridges.

making a new papyrus node which is more realistic and mark the old one deprecated,

-1, unnecessary, too complex and too disruptive.

Closing due to #2710

Was this page helpful?
0 / 5 - 0 ratings