Minetest_game: Rename inner/outer stairs

[Wuzzy2]

Please rename the inner and outer stairs. Oh, I mean the stairs outer and stairs inner. ;-)

Current names:

• “Tin Block Stair Inner”.
• “Tin Block Stair Outer”.

And so on. This is wrong. Please change it to:

“Inner Tin Block Stair”.
“Outer Tin Block Stair”.

[SmallJoker]

Why are they wrong? Looks fine to me:
For the current inner stairs, the cut-out edge is on the inside. So what results in the stair effect is on the inside.
The current outer stairs have the cut-out edges outside, which means the stair effect (step-up) occurs on the outside.

EDIT: Oh, now I see. Moving the actual node name in between "inner" and "stair", respectively between "outer" and "stair".

[paramat]

:+1: Quick and easy job.

[TumeniNodes]

If you rename them this way, it will reflect where they show up in inventory.
At least I "think" I remember this being the reason I set the names that way. I could be mistaken.
I am definitely not objecting because it is more sensible to the mind this way, I am just saying check it out first

[Napiophelios]

@TumeniNodes : I think this is about descriptions of inventory items,
not the actual nodes' names.

I think the proposed name changes are awkward sounding.
Maybe just leave it how it is.

[Xaleth]

Or just "Tin Inner Stair".
And "Tin Outer Stair".

On 12/02/2017 02:27 PM, Napiophelios wrote:

@TumeniNodes : I think this is about descriptions of inventory items,
not the actual nodes' names.

I think the proposed name changes are awkward sounding.

This sounds more natural to me:
“Tin Block Inner Stair”.
“Tin Block Outer Stair”.

[paramat]

Best it specifies the parent node, so 'block' is needed.

[TumeniNodes]

I think this is about descriptions of inventory items,
not the actual nodes' names.

I think the proposed name changes are awkward sounding.
Maybe just leave it how it is.

@Napiophelios , probably. I seem to always forget about that.
"node name" Inner Stair
"node name" Outer Stair
Would stick to the naming theme better, I would +1 that
It is definitely something which should probably not waste too much time hanging around. If a couple devs agree on this then just make the changes and be done with it... Next! ha

[paramat]

Actualy this is not possible as the word 'stair' is in the definition table, and if we change how the description is constructed we break mods.

[Wuzzy2]

WTF?! Are you serious? It is not possible to change a node description? OMG. This is just stupid.
You literally just need to move the word “Inner/Outer” before the original stair/slab description, instead of after it.

E.g. “Inner \

Another solution would be to just use brackets. Like “Tin Block Stair (Inner)”.

Another solution would be to add parameters to set the inner and outer stair node descriptions explicitly. This would also make them translatable, should MTG ever actually adopt the client translations. If you just use string concatenation (like now), translating will become a problem in future (not all languages use the same word order). In case those params are not set, you can still fall back to the auto-constructed strings.

Why is compability a concern? The inner and outer stairs have NOT been part of a release yet. If mods depend on a bleeding edge it's their fault if things break.

[paramat]

The description lines in each registration are for all stairs not just inner/outer, so it could break mods.
However moving 'inner/outer' before the node description would be ok.

[paramat]

I was trying to do "Tin Block Inner Stair" which would have been impossible, and forgot your suggestion is possible.

[paramat]

1968 merged.

Good suggestion, thanks.