Minetest_game: No bones when died on a rope

[verymilan]

Hi there,

i just fighted with someone and he died on a rope.
There were no bones dropped.

I also had no log about the bones (i added notes to the mod).

In our case, it was a xdecor:rope.

[ghost]

Bones node checks for air above, if not found then +1 Y above that. If neither spot is air then bones node fails to place.

Perhaps bones should find air _near_ where player died, instead of _above_.

[ExeterDad]

If he had nothing in his inventory there would not be bones either.

[verymilan]

If he had nothing in his inventory there would not be bones either.

but he had.

[ghost]

Yes, if you lack items, no bones node is placed. In this case it appears that the player had inventory and there were no air nodes above him by two.

This can be fixed by finding air around the player. If they die inside an unprotected stone node, that should be replaced. Currently, the only thing a bones node will replace is a node that is buildable_to. (?)

I think that a bones node should be placed regardless of whether a player holds items.

[paramat]

'find node near' looking for air in a 1-node radius would be better, can anyone make the PR?

[tenplus1]

Fixed: https://github.com/minetest/minetest_game/pull/1282

[paramat]

1282 merged.