Minetest_game: Rotated stair rendering not perfect

[Fixer-007]

Here is basic scenario with reversed stair (look in middle and little below). Minecraft rendering is way better, while Minetest has rotated texture that looks bad and out of place. I think slabs also have this problem. Any concerns about this?

How it looks in Minecraft:

[RHRhino]

@Fixer-007 Not only the texture is a problem, also the lighting. Nodeboxes are lighted differently than full blocks. I think it is not fixable until the lighting has been fixed before.

[paramat]

This is expected, the texture is rotated as is necessary for most uses.

[Fixer-007]

I understand that in some way it is a feature actually, but it looks not good in some cases. Not sure if needs closing, maybe this needs discussion? Or everyone is fine with the way it is made?

[paramat]

Indeed it looks bad here due to the shading. The fix would be to have an option to not rotate the textures when the shape is rotated.

[tobyplowy]

@Fixer-007 I also think the textures Look bad on upside down stairs
@paramat it's not only the shading it's also the textures, it's mostly the textures actually.

[paramat]

Yeah i mean the shading (highlight and shadow) i used on the texture, that assumes light coming from above.

[tobyplowy]

@paramat oh okay sorry for the misunderstanding :D

[Fixer-007]

The fix would be to have an option to not rotate the textures when the shape is rotated.

That will be nice, maybe even specified on per block basic in lua.

[paramat]

Yes per-node.

[tobyplowy]

@Fixer-007 @paramat @RHRhino will this get fixed?

[Fixer-007]

maybe in a future

[RHRhino]

Maybe we can solve this by adding another tool next to the screwdriver? One tool to only rotate the node and one tool to only rotate the texture?

[tobyplowy]

@RHRhino I doubt that will work but +1 for me

[paramat]

I'm not sure it would be possible to have an option to not rotate textures when a nodebox is rotated, the textures may be locked to the shape. Creating differing nodes to fix this would result in 24 nodes for the 24 rotations.

[RHRhino]

I'm not sure it would be possible to have an option to not rotate textures when a nodebox is rotated, the textures may be locked to the shape.

@paramat Oh I should have mentioned that I only mean rotations for nodeboxes with the same textures on all sides (like in this example of the stone bricks stairs), so I'm talking about all stairs and slaps in minetest_game. It does not make sense to only rotate the shape of a cube or to only rotate the textures of a nodebox with different textures, which are propably shape depenend.
BTW while thinking about it, I recognized that we don't really need texture rotation (therefore also the other tool) for nodeboxes with the same textures on all sides at all.

[rubenwardy]

It seems the conclusion is that this is an engine issue? Fixable by adjusting lighting or stopping textures from rotating with the node box

[paramat]

Yes it's more of an engine issue, but not sure this should be closed.

[paramat]

We could add another bit to facedir that selects whether to rotate the texture too.
We should discuss this in engine.

[Fixer-007]

Should I open this in engine section?

[paramat]

Yes please.

[Fixer-007]

and I forgot to reopen this in engine section...