Minetest_game: Items should be picked up If You Walk into them (not by hitting them)

[tobyplowy]

Now you have to sort of Hit the item to pick it up this is okay but if you have a lot of items scattered around this can be extremely annoying I speak from experience UHhhhhhh. also it's faster en more efficient to just walk into it and just pick it up (NOTE) there would be a timer on it so you don't instantly pick it up again maybe like Five Seconds?

[NathanSalapat]

There is a mod that does this item_drop.

[C1ffisme]

@NathanSalapat "There is a mod" isn't a good argument, since it prohibits other ideas from mods becoming features in the game.

I would personally enjoy this, but only for items dropped by TNT, and other players. It would be annoying to drop an item, only to pick it up again.

[tobyplowy]

@C1ffisme yes there would be a timer on it so you don't instantly pick it up again maybe like Five Seconds?

[tobyplowy]

@NathanSalapat The fact that it is a Mod doesn't mean it can't be added to the game. (At least That's My opinion) :/

[C1ffisme]

@tobyplowy My basic idea is that the clicking to get items feature should remain, and only certain objects can be picked up again. Throwing an item? If you need to pick it back up, you can probably do that with your mouse. Blowing up TNT? You probably need to catch all those items. It's a bit annoying.

[ghost]

I think it would be ideal to automatically pickup an item as you walk immediately over it, and that this behavior ought to be settable by the client.

[DonBatman]

I like the idea of item pickup but only in minetest_game. The engine should remain as is. I am thinking of games that would need you to pick up items.

[tobyplowy]

@DonBatman It Could be a setting in the mod It Self so we can program it so you don't pick it up but have to click it.

[tobyplowy]

@everamzah Yes That's exactly What I was trying to say Thank You For commenting :smile:

[paramat]

:-1: It's more convenient for a player but much more complex to do this, Minetest is simple for good reason. I feel it's better to choose when or whether to pick something up, for example when in a confined space. It's also not needed as much since dug items go straight into inventory.
This is mostly an engine issue, it would be too slow in lua anyway.

[C1ffisme]

I feel it's better to choose when or whether to pick something up, for example when in a confined space.

@paramat Like I suggested, objects dropped by the player himself should not be picked up. But items from other players and TNT should be picked up.

This is mostly an engine issue, it would be too slow in lua anyway.

Surely not. Maybe moving many items towards you, but definitely not deleting an entity and preforming inventory actions every time you walk over the entity.

I think it would be ideal to automatically pickup an item as you walk immediately over it

This.

[paramat]

objects dropped by the player himself should not be picked up. But items from other players and TNT should be picked up.

That's even more complex :)

[tobyplowy]

@paramat lol thets true XD

[0-afflatus]

I'm so used to Minetest behaviour that picking up on collision would seem weird. It's a long-running argument and the existence of a mod does make this possible. If you're arguing for an engine change you really do have to come up with a good argument as to how this will benefit the game and be better than a mod.

[C1ffisme]

@paramat Not really, all that would have to be done is to add a player variable to dropped items. This variable is set to the player that dropped the item. The player whose name is in the variable cannot pick it up automatically, but can punch it.

TNT would set the variable to nil, so that any player can pick it up.

[sofar]

Way too complicated.

First, I'm not for including this as a default, unless the whole drop-on-dig model gets changed as well.

Second, each dropped item has an age timestamp. Just don't allow auto-pickup of items that have an age less than 2 seconds, and the problem is solved.

[C1ffisme]

@sofar Eh... Okay.

[tobyplowy]

@C1ffisme I'm confused :smile:

[tenplus1]

Personally I prefer that players need to punch dropped items to pick them up, just walking over them to do so isn't realistic and a pain if you are walking through an area with loads of dropped items from other players.

[C1ffisme]

@tobyplowy I was too tired to come up with a sensible argument at the time.

Our community seems to have trouble giving into another's opinions, and knowing when an argument is lost, and it's just best to stop.

@tenplus1 It's realistic, but it's not practical. With the changes to TNT that @sofar has made, TNT drops a lot of items, and it's not very easy to find all of the itemstacks, point at their rather small selection boxes, and click, for every itemstack. Often the server deletes all of the items before you can get them all.

[sofar]

@C1ffisme the last version of tnt (just merged) keeps the amount of stacks under control.

I don't want to make items pickup automatically since I want some deterrence from using TNT as a regular tool. Making it easy to pick up items from a TNT explosion would make it too convenient.

[C1ffisme]

@sofar But that is... What TNT is...

A tool.

For mining.

And not collecting quite as much cobblestone. (Since TNT only drops 1/3 as much cobblestone.)

I can't see any other reason for having TNT in vanilla Minetest, other than for traps in multiplayer. (Or for simple fun in creative mode, but survival players would not concentrate on blowing things up.)

[paramat]

I don't want to make items pickup automatically since I want some deterrence from using TNT as a regular tool. Making it easy to pick up items from a TNT explosion would make it too convenient.

I agree.

Our pickup sytem was a concious decision for simplicity and a difference from MC.

[C1ffisme]

@paramat I think it's a lot simpler to run over items then to aim and punch.

Besides that, it's generic game behavior. When you run over coins/rings/items, you pick them up.

[tobyplowy]

@C1ffisme exactly It's a lot More convenient better and simpler And faster

[numberZero]

This should be configurable. Preferably in client but as that is not supported two lines in minetest.conf would be fine too (one for MC-style drops and one for pickup).
item_drop is good but is not configurable (I personally like MC-style pickup but not drop) and manual drop didn’t work properly in version I tried

[paramat]

I'm talking about code simplicity, MC behaviour is complex to implement.

[sofar]

I'd have no issues with item_drop or a better version being _bundled_ together with minetest. But I still don't want it enabled by default as the poster requests.

I suggest closing this feature request.

[paramat]

This is more of an engine issue, as the only efficient way to do this is there. Perhaps you could open an engine issue, then if it is added you can request it here in MTGame.