Minecraftforge: [1.16.2] Sneaking on non-liquid block makes player swim

Created on 13 Aug 2020  路  10Comments  路  Source: MinecraftForge/MinecraftForge

Minecraft Version: 1.16.2

Forge Version: 33.0.2

MCP Version: 20200813-1.16.1

Steps to Reproduce:

  1. Find a non-liquid block
  2. Use the sneak control and hold

Description of issue:
When the player does a sneak on a non-liquid block, the player appears to be swimming on the ground.

Triage

Most helpful comment

Alright so when I use the 20200723-1.16.1 mappings it works fine, but when I use the 20200813-1.16.1 mappings I get this problem.

All 10 comments

Cannot reproduce this.

Can you provide a screenshot?

image

image

I cannot reproduce.

Alright so when I use the 20200723-1.16.1 mappings it works fine, but when I use the 20200813-1.16.1 mappings I get this problem.

There's an issue with the isSwimming() call under ClientPlayerEntity. Also, it probably needs to override from the super class.
image

In 0723, this function is named differently.
image

Likely, the mappings spreadsheet needs to be updated, as there is already a working isSwimming function.

For reference, the existing isSwimming function:
image

Changing that method does indeed fix the issue. I'll publish a new version soon.

Once the release is published, this issue will be closed.

Was this page helpful?
0 / 5 - 0 ratings