Minecraftforge: [1.14.2] HarvestDropsEvent not fired

Created on 16 Jun 2019  路  7Comments  路  Source: MinecraftForge/MinecraftForge

No calls to ForgeEventFactory.fireBlockHarvesting from Block.
There are probably other events not fired e.g FluidPlaceBlockEvent.

1.14 Confirmed Regression Stale

Most helpful comment

So this is still an issue, not sure if it's being looked at. If it's not then let me know and I'll make a PR to fix it.

All 7 comments

So this is still an issue, not sure if it's being looked at. If it's not then let me know and I'll make a PR to fix it.

@darkevilmac the Forge team have a lot of other stuff to focus on right now. Making a PR would probably be a good idea :)

@darkevilmac +1

Is this still Broken ?

Created a PR for a fix, feedback welcome. #5871

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

Oh forgot about this. I pushed the results of #6267, #6401 and #6554 to 1.14.4 last night, so it is now possible to use the global loot modifiers feature to achieve most/all of the same things HarvestDropsEvent would allow.

Was this page helpful?
0 / 5 - 0 ratings