Minecraftforge: [1.13] RuntimeEnumExtender references deleted EnumHelper class

Created on 2 Jan 2019  路  4Comments  路  Source: MinecraftForge/MinecraftForge

It appears that EnumHelper was accidentally deleted in this commit c4cf950863256ed048a46e098401a969dfe4cb2e as it is still used in RuntimeEnumExtender.

https://github.com/MinecraftForge/MinecraftForge/blob/6baddc7e261d959301392e02787cea4aebd1d986/src/fmllauncher/java/net/minecraftforge/common/asm/RuntimeEnumExtender.java#L184

1.13 Bug
Source
picture JDLogic

All 4 comments

It was not accidental, we just need to resurrect that one method and place it elsewhere.

tterrag1098 picture tterrag1098 on 3 Jan 2019
👍1

I have a proposed patch here: https://github.com/tterrag1098/MinecraftForge/commit/f86551a9835d065cbb0f2d5ef4d0ce9586c1d844

Just waiting on approval of my implementation (I'm not 100% sure this is the intended use case of UnsafeHacks)

Edit: take 2: https://github.com/tterrag1098/MinecraftForge/commit/0d1a2f2af343bbd6907a74607ff156eefa6cfcc3

tterrag1098 picture tterrag1098 on 17 Jan 2019
👍1

Is this resolved now?

bs2609 picture bs2609 on 19 Jan 2019

Yes, fixed via 0d1a2f2af343bbd6907a74607ff156eefa6cfcc3

tterrag1098 picture tterrag1098 on 19 Jan 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Ruuubi picture Ruuubi  路  3Comments
DaedalusGame picture DaedalusGame  路  3Comments
Tamaized picture Tamaized  路  3Comments
tterrag1098 picture tterrag1098  路  3Comments
ErikBigDev picture ErikBigDev  路  3Comments