Minecraftforge: Add hook for getting villager professions with unknown ID

Created on 24 Nov 2018 · 5Comments · Source: MinecraftForge/MinecraftForge

Currently, there's only VillagerProfession#getRandomCareer() and VillagerProfession#getCareer(), however there is no way to remove the professions or to iterate through them.
Since the ID is assigned dynamically, there is also no way to get a specific modded career (vanilla careers pretty much have static IDs),
and since there is no getSize() exposed for the career list, one cannot easily iterate over all careers.

1.12 Feature Stale

Source

UpcraftLP

Most helpful comment

A map can be added, but as the number of careers is probably quite small, simple linear searching of the list would probably be fine anyway.

bs2609 on 24 Nov 2018

👍4

All 5 comments

So, something like a getCareer(String) method to get a career by name and perhaps a view-returning getCareers() method to see all careers?

bs2609 on 24 Nov 2018

ideally, yes, however that'd need to change the careers list to a map.
So I'd be fine with just getting access to that list, or the size of it at least so I can properly iterate over it.

UpcraftLP on 24 Nov 2018

A map can be added, but as the number of careers is probably quite small, simple linear searching of the list would probably be fine anyway.

bs2609 on 24 Nov 2018

👍4

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!