Minecraftforge: Furnace Doesn't Save Fuel As Int to the disk

[jredfox]

furnace stores and parses fuel time burn time etc as int but, then when saving they are all casted to short. This is a bug causing mods to have nor more then short max value for fuel without breaking minecraft furnace.

Short max value isn't much greater then the default coal block if I recall it's not enough for op rare fuel time so for that reason and others it should be high priority

[mcenderdragon]

Short.MAX_VALUE would be 32767. This should be 163.83 items.

[jredfox]

has nothing to do with items it's the burntime burntime all and cooktime need to be their original int values that's stupid loosing fuel data

[SkyHawkB]

Again, you're pointing out a "problem" in the Minecraft code, and not saying why it should be fixed.

[KingLemming]

This is just a Mojang holdover from when the furnace used to save (and read) these as shorts.

There's a case to be made for adjusting this, but it's simple enough that maybe a PR is the right way to do it, and not just an issue.

[jredfox]

either keep everything short or keep everything as int because keeping it as short is loosing data and fuel handlers return int as well as everything else it's a vanilla optimization do not support it when mods return int

[KingLemming]

Sure. Yes. Make the PR.

[jredfox]

I shouldn't have to make a pull request for 3 lines of code especially when there is no actual minecraft source code to edit here on the github. Can't make a pull request if I don't know how to use MCP .patch files.

[illyohs]

uhhh after about five seconds of searching on the readme http://mcforge.readthedocs.io/en/latest/forgedev/

[loordgek]

fixed in 1.13 https://github.com/MinecraftForge/MinecraftForge/blob/1.13-pre/patches/minecraft/net/minecraft/tileentity/TileEntityFurnace.java.patch