Minecraftforge: Provide a TE for getDrops

[williewillus]

Currently, to access TE data in getDrops, you have to do some trickery involving deleting the block later than normal (see patches to BlockFlowerPot).

However, recently a nullable TileEntity argument was added in vanilla to harvestBlock, which means we can just pass it directly to getDrops (via a threadlocal similar to the silk check state).

This would make it easier/more intuitive to read TE data for getDrops instead of having to do tricks.

[KingLemming]

There's not any trickery needed. You have an IBlockAccess and a BlockPos. You can grab the tile yourself without issue - I do this all the time with CoFH stuff.

[KnightMiner]

I've had issues with this myself as well. Yes, you have world access in Block::getDrops, but the TE is almost always null. I've had to override Block::onRemovedByPlayer to change the order block breaking happens in order to make it work.

[williewillus]

When harvesting by digging, getdrops is called after the block (and TE) are already deleted from the world.

[HenryLoenwind]

KingLemming, that is exactly what "some trickery involving deleting the block later than normal" meant...

[raoulvdberge]

The current state is that it's a confusing mess.

[JamiesWhiteShirt]

Looking at the related PR, this is scheduled to be fixed in 1.13.

For now, @McJty demonstrates an example workaround here: https://twitter.com/McJty/status/1002546886161596416

[HenryLoenwind]

That is the standard workaround everyone has been using for ages...

[JamiesWhiteShirt]

You might not find it useful. I left it here for those who might.

[raoulvdberge]

It's not a nice workaround, this change makes it much nicer.

[asiekierka]

Personally, I simply implement my own harvestBlock, as shown here. It's the cleanest solution I've found, though coremods which modify harvestBlock might not like it . . .

[HenryLoenwind]

...and then people ask why implementing breaking a plant with a hoe is such a big deal in the Farming Station...

[stale[bot]]

This issue has been automatically marked as stale because it has not had activity in a long time. If this issue is still relevant and should remain open, please reply with a short explanation (e.g. "I have checked the code and this issue is still relevant because ___." or "Here's a screenshot of this issue on the latest version"). Thank you for your contributions!

[stale[bot]]

This issue has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.