Minecraftforge: Mod advancements are not loaded
Fairly obvious thing to do, but just thought we should have an issue tracking it.
This should be a lot more straightforward than recipes, as we're not editing the format (afaik)
williewillus
All 5 comments
@williewillus We might need to change advancement and loot table loading to be implemented by mod containers like how those language files are read.
liach
on 18 Jun 2017
@liach An event in AdvancementManager.reload just after AdvancementManager.loadBuiltInAdvancements might also be useful to avoid some ugly core-modding and dynamically add custom advancement objects.
Landmaster
on 18 Jun 2017
@liach what for?
williewillus
on 18 Jun 2017
I think this is a breaking change, so this has probably to be done before the deadline...
mcenderdragon
on 25 Jun 2017
It's not a breaking change, but yes it's done. https://github.com/MinecraftForge/MinecraftForge/commit/a4fb33d9459ac73831baec908f18d8f19f3cd6c0
LexManos
on 28 Jun 2017
Related issues
Tamaized
路
3Comments
Sir-Will
路
3Comments
williewillus
路
3Comments
williewillus
路
3Comments
bs2609
路
3Comments
Most helpful comment
It's not a breaking change, but yes it's done. https://github.com/MinecraftForge/MinecraftForge/commit/a4fb33d9459ac73831baec908f18d8f19f3cd6c0