Minecraftforge: Recipes not loaded from jars

[Xalcon]

It seems the loading mechanism for loading JSON recipes is currently broken. JSON recipes work just fine in dev, but as soon as you try running it from a jar, the recipes no longer get loaded.

This issue has been replicated with multiple mods available on curseforge.

I was able to track down the issue to the CraftingHelper.loadRecipes() method. It seems this check always fails - even if its a jar file.

Tested with Forge 2333

[Xalcon]

I toyed around with the code a bit and I was able to load the jar, recipes work!
The issue is the URI source = mod.getSource().toURI(); in https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/src/main/java/net/minecraftforge/common/crafting/CraftingHelper.java#L645
This always returns an URI with the file:/ scheme.
I simply added the following code afterwards, the jar is loaded just fine, recipes are working:

if(mod.getSource().exists() && mod.getSource().toString().endsWith(".jar"))
    source = new URI("jar:" + source);

Since I'm not sure if this is the proper approach to fix this, I wont do a PR. Maybe someone else can pick this up tho :)

[williewillus]

yup, looks like File.toURI() is defined to always return a file:// uri.

javadoc

[fnuecke]

Alternative patch that also appears to work (no idea about dev tho, don't know how to test that) would be to add this before the if ("jar"..., feels somewhat hacky due to the getClass(), though:

            if (mod.getMod() != null && mod.getMod().getClass().getResource("/assets/" + ctx.getModId() + "/recipes/") != null)
            {
                try
                {
                    source = mod.getMod().getClass().getResource("/assets/" + ctx.getModId() + "/recipes/").toURI();
                }
                catch (URISyntaxException e)
                {
                    FMLLog.log(Level.ERROR, e, "Error accessing mod jar: " + e.toString());
                    return false;
                }
            }

[williewillus]

I personally prefer the former :P

[LexManos]

Humm interesting, oh well.
I was just trying to mimic vanilla's loading.
The solution is simple, mod.getSource().isFile()/isDirectory() like everything else does.

[williewillus]

the subtle difference is that vanilla uses Class.getResource().toURI which is URL -> URI. the call being made here is File -> URI

[ThatGamerBlue]

any way around this until patch gets merged?

[mezz]

Fixed here https://github.com/MinecraftForge/MinecraftForge/commit/a2749e450760f7e83dc88a4b5cdf2e9811620e75