Minecraftforge: Disable mods

Created on 23 Mar 2016 · 26Comments · Source: MinecraftForge/MinecraftForge

I've noticed that all gui for disabling mods is present but, the code for doing so is not. Is this something that is planned to happen in the future?

Feature Stale

Source

BinaryAura

👍2

Most helpful comment

You can see some stuff on cpw's github like the modlauncher progress:
https://github.com/cpw/modlauncher
and coremods system: https://github.com/cpw/coremods
There is more that is not public yet, he showed and talked about some on his stream but I do not see any video recordings unfortunately. https://mixer.com/voxcpw

mezz on 12 Jan 2018

👍3

All 26 comments

It is already working, it's up to mods to support it. Most can't use it though because they have blocks and items

williewillus on 23 Mar 2016

What do you have to do to get it to work then? I looked at the GuiModList.java and it doesn't have any actions for clicking disable. I'm currently using 1722.

BinaryAura on 23 Mar 2016

As I said, most mods can't use it because they add blocks and items (which REQUIRE a restart). Some minor aesthetic mods (to my knowledge) can do it, but it all has to be coded in by the mod itself - it's not a forge issue

williewillus on 23 Mar 2016

Ok, I'm have trouble get the button to do anything, then. What is necessary to get Forge to turn the mod off? I set canBeDeactivated to true but, the only visable change was the Disable button was then Black rather than Red.

BinaryAura on 23 Mar 2016

The button simply does not have an action in GuiModList. But one can use ActionPerformedEvent to do something on button press. But the button first needs to be activated via button.enabled = truefor the event to fire.

iTitus on 23 Mar 2016

So does that simply mean that forge isn't allowing mods to be deactived in this manner and if so why have the button?

BinaryAura on 23 Mar 2016

In 1.9 @Mod.canBeDeactivated() is not even used anywhere.

iTitus on 23 Mar 2016

Loader.runtimeDisableMod(modId) is not called either.

iTitus on 23 Mar 2016

That method isn't called in 1.8.9 for 1722. But it was the only location that I found that calls the FMLModDisabledEvent via LoadController#disableMod()

BinaryAura on 23 Mar 2016

This led me to believe that Disabling Mods in game is simply not supported at this time. If this is true, will it ever be?

BinaryAura on 23 Mar 2016

Technically it is supported, the framework seems to be there, but it is not implemented or thoroughly tested.

iTitus on 23 Mar 2016

That's what I saw as well. I just called it not supported do to the inability to do it in game. Do you know if there is any reason why this is?

BinaryAura on 23 Mar 2016

I told shit

iTitus on 23 Mar 2016

I found it

iTitus on 23 Mar 2016

BinaryAura on 23 Mar 2016

It does a few things, like changing the color of the button (as you said). I missed that while I was looking.
The main point is that it can forcefully change the Disableabilty of your mod based on dependencies.
But still: no button listener.
Commit: https://github.com/MinecraftForge/MinecraftForge/commit/751c5e39a485b95fd6a5dfcef02429739eedb561

iTitus on 23 Mar 2016

I wouldn't mind trying to get this to work but, it'd have to wait until my current mod gets to beta in a month or two.

BinaryAura on 23 Mar 2016

All done by @cpw in the end of 2013 while revamping a lot of Forge's codebase.

iTitus on 23 Mar 2016

I just know that coremods with a ModContainer can be disabled when returning false in registerBus(EventBus bus) call.

liach on 23 Mar 2016

I left it dead because as has been pointed out, 99% of mods can make no use of it. I frankly have billions of other activities that are a priority and negative infinity time. This has gotten left by the wayside. Actually removing it would take time I don't have too..

cpw on 23 Mar 2016

As I pointed out before, after I get my current project to beta, I could get this working. Perhaps with a restart inquiry? So, many other Mods could use it too.

BinaryAura on 23 Mar 2016

@diesieben07 added labels [Feature]

Actuarius on 26 May 2016

This issue has been automatically marked as stale because it has not had activity in a long time, and will be closed if no further activity occurs. If this issue was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.