Min: Toneden free download - redirect failure [window.open not supported]

[Smona]

When trying to download a free song from toneden.io, the page which redirects from a soundcloud verification gets stuck, making it impossible to download.

Example of where this happens

[PalmerAL]

I'm guessing this is probably because we don't support window.open very well.

[miere]

The same happens on many sites when I try to use Facebook or Twitter login integrations...

[PalmerAL]

from #446:

Site netlify.com (and many others) do authentication after logging in in the new window and refreshing the main window.

Problem:
window.opener is nuil.

See

electron/electron#9533
electron/electron#9961
jiahaog/nativefier#164

[PalmerAL]

@igk1972 see #440:

Muon does seem to solve a lot of the issues with this (and support for popup windows would be nice as well). The biggest problem with Muon (and what's stopped me from considering a switch in the past) is that there seems to be almost no documentation on it. Brave's added a bunch of API's specific to their browser, and changed a bunch of things about how Electron's existing features work, and the only way (unless I'm missing something?) to figure out how to use it is to look at Brave's source code and guess what the correct API is. Meanwhile, glancing through their issue tracker, they don't seem to answer questions about it (which I completely understand, they're not obligated to, but it's a problem for us). If we migrate to Muon, I think we're going to have a lot of problems with this; I'm not really sure what the best option is here.

[PalmerAL]

But I do agree that Muon has a lot of advantages, maybe it's worth trying to figure out how to use it based on the Brave source code.

[PalmerAL]

Brave has announced that they're stopping development on Muon (https://brave.com/development-plans-for-upcoming-release/), so I guess we need to figure out an Electron-based solution for this.

[dbfreem]

Is this still something being considered? I ran into a situation today where popups not being supported was a blocker for me using min.

[PalmerAL]

I'd like to have this too, but I'm not sure how feasible it is. We might be able to hack something together using preload scripts, and send synchronous IPC messages between the parent and the child window, but I'm not sure how well it would actually work. If it doesn't, then this would need to be implemented in Electron, which I think would require some pretty significant changes to Electron (although I'm not sure exactly what changes would be required). If someone wanted to work on it, I'm guessing they'd be willing to support it, but it doesn't seem to be a priority for anyone contributing to Electron right now.

[lawrencenull]

It seems electron does natively support window.open now through several methods.

https://electronjs.org/docs/api/window-open

[PalmerAL]

Oh, wow, you're right; everything does seem to work as expected when using the nativeWindowOpen option. (I'm wondering if that changed at some point, because I'm almost certain I tried that before, but maybe I'm just remembering wrong?)

[lawrencenull]

They changed it at some time or another. I was having the same problem a few months back and ran into this.

[larskouwenhoven]

Is there any outlook on a solution to this issue? It's the one reason keeping me from switching to Min, since I e.g. use Feedly on a daily basis, and cannot log in now.

[PalmerAL]

It works if you add nativeWindowOpen: true here and remove this. However, I don't think we actually want websites to be able to open arbitrary popup windows, since that's easy to abuse. Ideally, we could make the new window open in a tab, but Electron doesn't support that right now; I'm not sure how much work it would be to implement. Alternatively, we could make a popup blocker, and require you to give permission to websites before they can open popups. I think that would be simple-ish to do, although it would be rather annoying to use.

[BenStigsen]

I think the permission popup would be the best approach or some setting that allows popups globally. Because having to mess with the code to be able to access sites that require Google authentication popup doesn't seem very user-friendly.