Microsoft-authentication-library-for-js: Modified copy of msal-angular code inside samples/msal-angular-v2-samples/angular10-browser-sample?

Created on 21 Nov 2020  路  2Comments  路  Source: AzureAD/microsoft-authentication-library-for-js

Library

Documentation location

  • [x] Documentation does not exist

Description

The Angular 10 example does not use the code from @azure/[email protected]. Instead it has copied and modified the code, see https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/samples/msal-angular-v2-samples/angular10-browser-sample/src/app/msal.

Why is that? Does it mean we can't use the official @azure/[email protected] library, but instead have to copy the code from the example? What happens with bug fixes? Will they be committed to both, @azure/[email protected]` and the example project?

documentation question

Most helpful comment

@restfulhead The angular10-browser-sample was created before @azure/msal-angular@2 was available to demonstrate how an app could use MSAL Browser directly. Going forward, applications should use @azure/msal-angular@2 and the new samples. We'll make sure to update the angular10-browser-sample to make it clear to look at the other samples, apologies for the confusion. cc: @jo-arroyo

All 2 comments

@restfulhead The angular10-browser-sample was created before @azure/msal-angular@2 was available to demonstrate how an app could use MSAL Browser directly. Going forward, applications should use @azure/msal-angular@2 and the new samples. We'll make sure to update the angular10-browser-sample to make it clear to look at the other samples, apologies for the confusion. cc: @jo-arroyo

Great, thank you for the clarification. That makes sense. I must have overlooked the sample in @azure/msal-angular@2.

Was this page helpful?
0 / 5 - 0 ratings