Microsoft-authentication-library-for-js: Wrong type for getAllAccounts, should be nullable

Created on 17 Nov 2020  路  2Comments  路  Source: AzureAD/microsoft-authentication-library-for-js

Library

Description

In all examples calling getAllAccounts() there is a check for null done, see here. But the type defined is not defined as nullable (as can be seen in IPublicClientApplication interface).

Expected behavior

It would be helpful to know, through typing as well, that the result can be null, or if that is not the case, to adapt the examples to match the current behaviour.

documentation msal-browser samples
Source
picture Calamari

Most helpful comment

@Calamari Thanks for pointing this out, looks like the sample needs to be updated. getAllAccounts will return an empty array if no accounts are found.

@derisen Could you please update the samples to check for currentAccounts.length === 0 instead of null?

picture tnorling on 17 Nov 2020
👍2

All 2 comments

@Calamari Thanks for pointing this out, looks like the sample needs to be updated. getAllAccounts will return an empty array if no accounts are found.

@derisen Could you please update the samples to check for currentAccounts.length === 0 instead of null?

tnorling picture tnorling on 17 Nov 2020
👍2

Closing as the samples have been updated

tnorling picture tnorling on 23 Nov 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

AbhaysinghBhosale picture AbhaysinghBhosale  路  3Comments
ssuvorov picture ssuvorov  路  3Comments
exequeryphil picture exequeryphil  路  3Comments
DarkLite1 picture DarkLite1  路  3Comments
jviney picture jviney  路  3Comments