Microsoft-authentication-library-for-js: CommonJS or AMD dependencies warning in Angular 10

Created on 29 Sep 2020  路  4Comments  路  Source: AzureAD/microsoft-authentication-library-for-js

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

Important: Please fill in your exact version number above, e.g. [email protected].

Framework

Angular 10

Description

Angular 10 provides a build warning. This seems to stem from the use of minimatch.

This is non-consequential, but would be nice to clean up.

Error Message

WARNING in C:...\node_modules\@azure\msal-angular__ivy_ngcc__\fesm2015\azure-msal-angular.js depends on 'minimatch'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:...\node_modules\minimatch\minimatch.js depends on 'path'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

WARNING in C:...\node_modules\minimatch\minimatch.js depends on 'brace-expansion'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Security

  • [ ] Is this issue security related?

Regression

  • [x] Did this behavior work before?
    Version:
    msal.angular 1.0.0

    MSAL Configuration

// not relevant

Reproduction steps

// not relevant

Expected behavior

Browsers/Environment

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Edge
  • [ ] Safari
  • [ ] IE
  • [ ] Other (Please add browser name here)
enhancement known-issue msal-angular

Most helpful comment

We'll be addressing this in MSAL Angular v2 (preview version coming soon!).

All 4 comments

This issue has not seen activity in 14 days. It will be closed in 7 days if it remains stale.

any news on this? we're just working on updating our npm packages and running into this same issue

We'll be addressing this in MSAL Angular v2 (preview version coming soon!).

Minimatch has been replaced in the latest alpha of MSAL Angular v2. Closing.

Was this page helpful?
0 / 5 - 0 ratings