Microsoft-authentication-library-for-js: Remove Build Output from Repo
Why is the build output in the repo? Makes it very hard to read PRs. Example #210.
- What are the real changes?
vs - What are the build output changes (I don't care about those...)
spottedmahn
All 8 comments
spottedmahn
on 16 May 2018
More noise:
spottedmahn
on 16 May 2018
@spottedmahn We are using the build output so we can refer to the files while writing dev apps for testing.
rohitnarula7176
on 22 May 2018
Oh, interesting.
This is not a common practice. I can't think of any other libraries that put their build output in their source repo. I hope you guys re-evaluate 馃槣
spottedmahn
on 22 May 2018
This really needs to be re-opened. There should be no build output in the src repo. I'm struggling to understand why you need to refer to these output files for dev apps in testing?
Plus if you're taking in Build output as part of the PR, what makes it "safe" to say that the Output is done from a clean build box, such as a controlled well know base set of tools, etc. to create the build. This is far from normal practice and there are other ways probably to achieve what you need, just don't understand the need.
cicorias
on 30 Oct 2018
@spottedmahn we are removing /dist in the upcoming release. We are working on a strategy for /docs, and they will have to remain for some time in github.
sameerag
on 1 May 2019
so, there's nothing wrong with the docs unless they're auto-generated. the /dist/*.js are all TSC emitted and non-sensical from a Git perspective to be within the repo. However, they DO need to be in any NPM or other package manager assets.
The Docs imho probably are OK - unless there is a move shift all docs and the pr/change process within the repo to docs.microsoft.com
cicorias
on 1 May 2019
@cicorias Sure. Yeah, we took some time since we were working on removing a legacy dependency on /dist in the test code. We already made the separation in our dev now and hence yes, we are on track.
For now we are stabilizing the comments to make the docs more relevant, but the strategy is evolving in parallel for the /docs.
sameerag
on 1 May 2019
Related issues
exequeryphil
路
3Comments
ArneMancofi
路
3Comments
baltuonis
路
4Comments
lecaillon
路
3Comments
spottedmahn
路
4Comments
Most helpful comment
This really needs to be re-opened. There should be no build output in the src repo. I'm struggling to understand why you need to refer to these output files for dev apps in testing?
Plus if you're taking in Build output as part of the PR, what makes it "safe" to say that the Output is done from a clean build box, such as a controlled well know base set of tools, etc. to create the build. This is far from normal practice and there are other ways probably to achieve what you need, just don't understand the need.