Micrometer: ElasticSample causes "Duplicate field 'name'" error in elasticsearch

[jkschneider]

cc / @jvalkeal

[prafsoni]

Hi, when in 1.1 release is scheduled? We are waiting on this... feature. So we can remove intermediate storage in atlas and move metrics directly to Elasticsearch.

[jkschneider]

@prafsoni Latest possible delivery date is September 1, but we could release a 1.1 earlier if there is a need and follow on with 1.2 for Spring Boot 2.1 later. Until this issue is resolved, Elastic support is broken.

[prafsoni]

@jkschneider We are targeting to get to production by the end of this quarter. If we can get Elasticsearch support before that, would be really appreciated.
We are still on Spring boot 1.5.x since Spring Cloud for 2.0 is not ready yet.
If required, I am open to contributing to the efforts.

[tkp1n]

@jkschneider Do you know which metric causes the issue? Or any other info to get a PR started? Would love to see this finally working without errors...

[tkp1n]

Found two obvious trouble-makers:
https://github.com/micrometer-metrics/micrometer/blob/0d0f51ac4b7d80fb5a73fc9f0e7a88fcc56a0c68/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java#L49

https://github.com/micrometer-metrics/micrometer/blob/0d0f51ac4b7d80fb5a73fc9f0e7a88fcc56a0c68/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/tomcat/TomcatMetrics.java#L256

Could we rename those tags or would this be too much of a breaking change?
Do you aim for a more general solution inside the elastic registry?

[jkschneider]

@tkp1n Yep, we are now renaming reserved words in Elastic as part of the default naming convention for the elastic implementation.