Meteor-files: onAfterRemove didn't get trigger

Created on 26 Jan 2017 · 11Comments · Source: veliovgroup/Meteor-Files

i follow the grid fs tutorial but i notice that onAfterRemove didn't get call after i use Images.remove({}) all the grid fs file is still there, i have to manually called it in a method

question

Source

lastday4you

All 11 comments

Hello @lastday4you ,

Show some of your code.
And how do you remove files. Is there a chance cursor (selection) is empty?

dr-dimitru on 26 Jan 2017

❤1

here is the collection code

export const Images = new FilesCollection({
  collectionName: 'images',
  allowClientCode: true,
  debug: Meteor.isServer && process.env.NODE_ENV === 'development',
  onBeforeUpload(file) {
    if (file.size <= 10 * 1024 * 1024 && /png|jpg|jpeg/i.test(file.extension)) return true;
    return 'Please upload image, with size equal or less than 3MB';
  },
  onAfterUpload(image) {
    // Move file to GridFS
    Object.keys(image.versions).forEach(versionName => {
      const metadata = {versionName, imageId: image._id, storedAt: new Date()}; // Optional
      const writeStream = gfs.createWriteStream({filename: image.name, metadata});

      fs.createReadStream(image.versions[versionName].path).pipe(writeStream);

      writeStream.on('close', Meteor.bindEnvironment(file => {
        const property = `versions.${versionName}.meta.gridFsFileId`;

        // If we store the ObjectID itself, Meteor (EJSON?) seems to convert it to a
        // LocalCollection.ObjectID, which GFS doesn't understand.
        this.collection.update(image._id, {$set: {[property]: file._id.toString()}});
        this.unlink(this.collection.findOne(image._id), versionName); // Unlink files from FS
      }));
    });
  },
  interceptDownload(http, image, versionName) {
    // Serve file from GridFS
    const _id = (image.versions[versionName].meta || {}).gridFsFileId;
    if (_id) {
      const readStream = gfs.createReadStream({_id});
      readStream.on('error', err => {
        throw err;
      });
      readStream.pipe(http.response);
    }
    return Boolean(_id); // Serve file from either GridFS or FS if it wasn't uploaded yet
  },
  onAfterRemove(images) {
    // Remove corresponding file from GridFS
    images.forEach(image => {
      console.log(image + "remove image");
      Object.keys(image.versions).forEach(versionName => {
        const _id = (image.versions[versionName].meta || {}).gridFsFileId;
        if (_id) gfs.remove({_id}, err => {
          if (err) throw err;
        });
      });
    });
  }
});

and here is my remove from the hook that called both server and client

Status.before.remove(function (userId, doc) {
  if (doc.image_id != null){
    Images.remove({_id: doc.image_id[0]});
  }
});

the file in the images collection is gone but the gridfs and chuck file is still there
and thank for the fast reply :)