Given that Mongo is forcing our hand by discontinuing all 32-bit support, the time has come for Meteor to consider dropping its 32-bit support. A few quick notes:
Considering the above, dropping 32-bit support could have the largest impact to Windows and 32-bit only *nix users. Given that only 0.97% of *nix based Meteor (1.4 and 1.5) usage in the last 30 days was on a 32-bit architecture (see https://github.com/meteor/meteor/pull/8864#issuecomment-314963360), the impact to *nix users should be fairly low. It would be great to see similar stats on the Windows side of things, but if Mongo has decided now is a good time to drop 32-bit support, they must have also decided the negative impact of doing so is quite low.
Can anyone think of any compelling reasons why we shouldn't drop 32-bit support? Please keep in mind we're referring to reasons against dropping 32-bit support for Meteor's officially supported architectures, so not including things like ARM, *BSD, etc.
Hi all - to help move this forward, here is a quick brain dump of changes that will need to be considered as part of this work. This list is not exhaustive, and some of it can only be handled by MDG, but it's a start. Feedback welcome!
os.linux.x86_32 / os.windows.x86_32 versions of the following (and start building / publishing os.windows.x86_64):dev_bundleRemove the x86_32 options from scripts/admin/publish-meteor-tool-on-all-platforms.sh and scripts/admin/publish-meteor-tool-on-arch.sh.
Update the Windows installer to look for meteor-bootstrap-os.windows.x86_64.tar.gz instead of meteor-bootstrap-os.windows.x86_32.tar.gz.
Disable the os.linux.x86_32 and os.windows.x86_32 build options available via build.meteor.com (and add os.windows.x86_64 if the build farm is sticking around).
Update the architecture checks in the following files, to disallow 32 bit architectures:
-> meteor
-> scripts/admin/launch-meteor
-> scripts/build-dev-bundle-common.sh
Disable the 32-bit Mongo version fetch when generating the Window dev_bundle.
Remove the meteor admin get-machine 32-bit options (os.linux.x86_32, os.windows.x86_32) and possibly add a os.windows.x86_64 option (if the build farm is sticking around).
Adjust the CLI's allowed architectures.
Adjust the host architecture strings used by the CLI.
Update all allowed architectures in the CLI help (removing os.linux.x86_32 and os.windows.x86_32, adding os.windows.x86_64).
os.linux.x86_32 / os.windows.x86_32, hello os.windows.x86_64 changes.@aadamsx There isn't even a development version of 3.6 yet, at least as far as I can tell. So technically MongoDB's holding things up as well.. 馃槃
@davidworkman9 -- snarky ain'tcha. I was using the term holding up loosely. :joy:
Can we get windows 64 bit pushed out sooner rather than later and then remove the 32 bit at a future date... specifically this is an issue as stated in #8871
@justbill2020 Meteor 1.6 now ships with Windows 64-bit support.
@hwillson This is awesome!!! thank you
@hwillson Do we still need/want to drop 32bit support (any time soon)? Could this wait until Meteor 1.7, perhaps? Or would it simplify things in the short term?
I still had to copy the 64 bit version of z7.exe to speed up the build times on the latest version... so that hasn鈥檛 been updated yet
@justbill2020 We added the code that was supposed to make that differentiation to the 64-bit dev bundle, as seen here:
Can you share the full path to the location that you're copying the 7z.exe to? Did you reinstall with the new Chocolatey installer? (If not, you're probably not using the 64-bit version of Meteor either.)
what's a new chocolatey installer? These are projects that I upgrade using the cli.
This is the path i'm i copy the 64 bit version of 7z.exe:
C:\Users\<USERNAME>\AppData\Local\.meteor\packages\meteor-tool\1.6.0\mt-os.windows.x86_32\dev_bundle\bin
@justbill2020 Please refer to the Windows installation instructions in the Meteor 1.6 release announcement! https://blog.meteor.com/announcing-meteor-1-6-abf30f29e2c6
@benjamn
Do we still need/want to drop 32bit support (any time soon)? Could this wait until Meteor 1.7, perhaps? Or would it simplify things in the short term?
Now that we're allowing 64-bit OS users to use Mongo >= 3.4, I think the pressure to drop 32-bit support has definitely been lessened. I still think it's something that should be done at some point (especially since it will simplify Meteor's codebase and deployment procedures), but waiting until Meteor 1.7 sounds good to me. Thanks!
This FR was implemented here https://github.com/meteor/meteor/pull/10933
Most helpful comment
Can we get windows 64 bit pushed out sooner rather than later and then remove the 32 bit at a future date... specifically this is an issue as stated in #8871