Metasploit-framework: smart_hashdump skips RID 1001

[nidem]

The line referenced below skips RID 1001. This is not a guest or support account on two systems I've tested it on.
https://github.com/rapid7/metasploit-framework/blob/749423da02092537e6a6a3a64f164e2f9d3db504/modules/post/windows/gather/smart_hashdump.rb#L243

[wvu-r7]

Maybe @darkoperator can explain what he was testing? 501 is correct for Guest, at least.

[darkoperator]

To be honest no clue I wrote it sooooo long ago. Since I have not used Metasploit in several years I bet dumping hashes for Windows 10 is broken in it since Windows 10 made some changes.

[github-actions[bot]]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[0x44434241]

I created a small PR for this because it seemed simple enough (famous last words...). Also fixed up formatting and added some docs while I was there.